Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754687AbdCJAVL (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Mar 2017 19:21:11 -0500
Received: from mga04.intel.com ([192.55.52.120]:32042 "EHLO mga04.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750781AbdCJAVJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Mar 2017 19:21:09 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,137,1486454400"; 
   d="scan'208";a="73733168"
Date: Thu, 9 Mar 2017 17:21:06 -0700
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: viro@zeniv.linux.org.uk, akpm@linux-foundation.org,
        konishi.ryusuke@lab.ntt.co.jp, linux-fsdevel@vger.kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        linux-nilfs@vger.kernel.org, ross.zwisler@linux.intel.com,
        jack@suse.cz, neilb@suse.com, openosd@gmail.com, adilger@dilger.ca,
        James.Bottomley@HansenPartnership.com
Subject: Re: [PATCH v2 5/9] dax: set error in mapping when writeback fails
Message-ID: <20170310002106.GD30285@linux.intel.com>
Mail-Followup-To: Ross Zwisler <ross.zwisler@linux.intel.com>,
        Jeff Layton <jlayton@redhat.com>, viro@zeniv.linux.org.uk,
        akpm@linux-foundation.org, konishi.ryusuke@lab.ntt.co.jp,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, linux-nilfs@vger.kernel.org,
        jack@suse.cz, neilb@suse.com, openosd@gmail.com, adilger@dilger.ca,
        James.Bottomley@HansenPartnership.com
References: <20170308162934.21989-1-jlayton@redhat.com>
 <20170308162934.21989-6-jlayton@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170308162934.21989-6-jlayton@redhat.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 397
Lines: 10

On Wed, Mar 08, 2017 at 11:29:30AM -0500, Jeff Layton wrote:
> In order to get proper error codes from fsync, we must set an error in
> the mapping range when writeback fails.
> 
> Signed-off-by: Jeff Layton <jlayton@redhat.com>

Yep, paired with the changes to filmap_write_and_wait() and
filemap_write_and_wait_range(), this seems fine.

Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>