Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753950AbdCJCdX (ORCPT ); Thu, 9 Mar 2017 21:33:23 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:42904 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751300AbdCJCdW (ORCPT ); Thu, 9 Mar 2017 21:33:22 -0500 Date: Fri, 10 Mar 2017 03:33:17 +0100 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 07/14] net: dsa: mv88e6xxx: rework ATU Remove Message-ID: <20170310023317.GJ22101@lunn.ch> References: <20170309233324.18539-1-vivien.didelot@savoirfairelinux.com> <20170309233324.18539-8-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170309233324.18539-8-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 383 Lines: 14 > -static int _mv88e6xxx_atu_cmd(struct mv88e6xxx_chip *chip, u16 fid, u16 cmd) > -{ > - u16 val; > - int err; > - > - if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_G1_ATU_FID)) { > - err = mv88e6xxx_g1_write(chip, GLOBAL_ATU_FID, fid); > - if (err) > - return err; I think this removal makes MV88E6XXX_FLAG_G1_ATU_FID unused. It should be removed from mv88e6xxx.h as well. Andrew