Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754402AbdCJEXt (ORCPT ); Thu, 9 Mar 2017 23:23:49 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36122 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752874AbdCJEXr (ORCPT ); Thu, 9 Mar 2017 23:23:47 -0500 Message-ID: <1489119824.28631.26.camel@edumazet-glaptop3.roam.corp.google.com> Subject: Re: [PATCH net, v1] dccp/tcp: fix routing redirect race From: Eric Dumazet To: Jon Maxwell Cc: gerrit@erg.abdn.ac.uk, davem@davemloft.net, edumazet@google.com, andreyknvl@google.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, ncardwell@google.com, dccp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jmaxwell@redhat.com, Eric Garver , Hannes Sowa Date: Thu, 09 Mar 2017 20:23:44 -0800 In-Reply-To: <1489116691-26264-1-git-send-email-jmaxwell37@gmail.com> References: <1489116691-26264-1-git-send-email-jmaxwell37@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 541 Lines: 19 On Fri, 2017-03-10 at 14:31 +1100, Jon Maxwell wrote: > As Eric Dumazet pointed out this also needs to be fixed in IPv6. > v1: Contains the IPv6 patch as well. > Fixes: ceb3320610d6 ("ipv4: Kill routes during PMTU/redirect updates.") > Cc: Eric Garver > Cc: Hannes Sowa > Signed-off-by: Jon Maxwell > --- > net/dccp/ipv4.c | 3 ++- > net/ipv4/tcp_ipv4.c | 3 ++- > net/ipv6/tcp_ipv6.c | 8 +++++--- Hi Jon. You forgot net/dccp/ipv6.c dccp_v6_err() has the same issue.