Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750938AbdCJFZ0 convert rfc822-to-8bit (ORCPT ); Fri, 10 Mar 2017 00:25:26 -0500 Received: from mga09.intel.com ([134.134.136.24]:41949 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750777AbdCJFZY (ORCPT ); Fri, 10 Mar 2017 00:25:24 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,138,1486454400"; d="scan'208";a="833024309" From: "Dilger, Andreas" To: Pushkar Jambhlekar CC: "Drokin, Oleg" , James Simmons , Greg Kroah-Hartman , "Hammond, John" , "Xiong, Jinshan" , lustre-devel , "devel@driverdev.osuosl.org" , LKML Subject: Re: [PATCH] Minor coding guideline Fix in lusture module Thread-Topic: [PATCH] Minor coding guideline Fix in lusture module Thread-Index: AQHSmM/fF3mAKv5Y5EWDU42W6QyvTaGOEeSA Date: Fri, 10 Mar 2017 05:25:22 +0000 Message-ID: References: <1489062127-23258-1-git-send-email-pushkar.iit@gmail.com> In-Reply-To: <1489062127-23258-1-git-send-email-pushkar.iit@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.70.242] Content-Type: text/plain; charset="us-ascii" Content-ID: <75339F67E1FC1941B8FC0F98DEDEA544@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1463 Lines: 58 On Mar 9, 2017, at 05:22, Pushkar Jambhlekar wrote: > Subject: Minor coding guideline Fix in lusture module I suspect the patchbot is unhappy with the subject line not containing anything useful, and not containing the subsystem name. Something like: staging/lustre/llite: replace "unsigned" with "unsigned int" > Replacing 'unsigned' with 'unsigned int' in vvp_pgcache_id. Remove double space, and reference function names like vvp_pgcache_id(). > Checkpath.pl passed. "checkpatch.pl" Cheers, Andreas > Signed-off-by: Pushkar Jambhlekar > --- > drivers/staging/lustre/lustre/llite/vvp_dev.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/llite/vvp_dev.c b/drivers/staging/lustre/lustre/llite/vvp_dev.c > index 12c129f7e..8d78755 100644 > --- a/drivers/staging/lustre/lustre/llite/vvp_dev.c > +++ b/drivers/staging/lustre/lustre/llite/vvp_dev.c > @@ -381,11 +381,10 @@ int cl_sb_fini(struct super_block *sb) > #define PGC_DEPTH_SHIFT (32) > > struct vvp_pgcache_id { > - unsigned vpi_bucket; > - unsigned vpi_depth; > - uint32_t vpi_index; > - > - unsigned vpi_curdep; > + unsigned int vpi_bucket; > + unsigned int vpi_depth; > + uint32_t vpi_index; > + unsigned int vpi_curdep; > struct lu_object_header *vpi_obj; > }; > > -- > 2.7.4 > Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation