Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261548AbTEUHee (ORCPT ); Wed, 21 May 2003 03:34:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261544AbTEUHea (ORCPT ); Wed, 21 May 2003 03:34:30 -0400 Received: from dp.samba.org ([66.70.73.150]:35565 "EHLO lists.samba.org") by vger.kernel.org with ESMTP id S261506AbTEUHb4 (ORCPT ); Wed, 21 May 2003 03:31:56 -0400 Date: Wed, 21 May 2003 17:44:56 +1000 From: David Gibson To: Greg KH Cc: Manuel Estrada Sainz , LKML , Simon Kelley , Alan Cox , jt@hpl.hp.com, Pavel Roskin , Oliver Neukum Subject: Re: request_firmware() hotplug interface, third round and a halve Message-ID: <20030521074456.GH23736@zax> Mail-Followup-To: David Gibson , Greg KH , Manuel Estrada Sainz , LKML , Simon Kelley , Alan Cox , jt@hpl.hp.com, Pavel Roskin , Oliver Neukum References: <20030517221921.GA28077@ranty.ddts.net> <20030521072318.GA12973@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030521072318.GA12973@kroah.com> User-Agent: Mutt/1.5.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 847 Lines: 24 On Wed, May 21, 2003 at 12:23:18AM -0700, Greg Kroah-Hartman wrote: > > +struct firmware_priv { > > + char fw_id[FIRMWARE_NAME_MAX]; > > + struct completion completion; > > + struct bin_attribute attr_data; > > + struct firmware *fw; > > + s32 loading:2; > > + u32 abort:1; > > Why s32 and u32? Why not just ints for both of them? And for that matter, I don't think there's any point using bitfields, 61 bits is not worth it. -- David Gibson | For every complex problem there is a david@gibson.dropbear.id.au | solution which is simple, neat and | wrong. http://www.ozlabs.org/people/dgibson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/