Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753998AbdCJH2x (ORCPT ); Fri, 10 Mar 2017 02:28:53 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36350 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750829AbdCJH2v (ORCPT ); Fri, 10 Mar 2017 02:28:51 -0500 Subject: Re: [PATCH v2 1/2] doc: bindings: Add bindings documentation for mtd nvmem To: Maxime Ripard References: <1488875164-30440-1-git-send-email-albeu@free.fr> <1488875164-30440-2-git-send-email-albeu@free.fr> <9f54978c-6d61-cf2c-fb2d-f5ef2af19e0f@gmail.com> <20170310063810.2efkb6j2kdgadalv@lukather> Cc: Moritz Fischer , Alban , Linux Kernel Mailing List , Srinivas Kandagatla , Rob Herring , Mark Rutland , David Woodhouse , Brian Norris , Boris Brezillon , Richard Weinberger , Cyrille Pitchen , Devicetree List , linux-mtd@lists.infradead.org From: Marek Vasut Message-ID: <26333808-3740-31ca-12ee-e4c6afc9ef29@gmail.com> Date: Fri, 10 Mar 2017 08:28:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170310063810.2efkb6j2kdgadalv@lukather> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2054 Lines: 51 On 03/10/2017 07:38 AM, Maxime Ripard wrote: > Hi Marek, > > On Fri, Mar 10, 2017 at 05:52:36AM +0100, Marek Vasut wrote: >> On 03/10/2017 05:06 AM, Moritz Fischer wrote: >>> On Thu, Mar 9, 2017 at 7:17 PM, Marek Vasut wrote: >>>> On 03/07/2017 09:26 AM, Alban wrote: >>>>> Config data for drivers, like MAC addresses, is often stored in MTD. >>>>> Add a binding that define how such data storage can be represented in >>>>> device tree. >>>>> >>>>> Signed-off-by: Alban >>>>> --- >>>>> Changelog: >>>>> v2: * Added a "Required properties" section with the nvmem-provider >>>>> property >>>>> --- >>>>> .../devicetree/bindings/nvmem/mtd-nvmem.txt | 33 ++++++++++++++++++++++ >>>>> 1 file changed, 33 insertions(+) >>>>> create mode 100644 Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt b/Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt >>>>> new file mode 100644 >>>>> index 0000000..8ed25e6 >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/nvmem/mtd-nvmem.txt >>>>> @@ -0,0 +1,33 @@ >>>>> += NVMEM in MTD = >>>>> + >>>>> +Config data for drivers, like MAC addresses, is often stored in MTD. >>>>> +This binding define how such data storage can be represented in device tree. >>>>> + >>>>> +An MTD can be defined as an NVMEM provider by adding the `nvmem-provider` >>>>> +property to their node. Data cells can then be defined as child nodes >>>>> +of the partition as defined in nvmem.txt. >>>> >>>> Why don't we just read the data from MTD and be done with it ? What's >>>> the benefit of complicating things by using nvmem ? >>> >>> Well because usually stuff like MAC addresses etc are stored in eeproms. >> >> But eeproms are already supported, see drivers/misc/ . > > This the old, free for all, way to support eeproms. We have a proper > framework for them now, and it's called nvmem. Ha, so that's why this patchset, I see. Thanks for clarifying. -- Best regards, Marek Vasut