Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932371AbdCJIgJ (ORCPT ); Fri, 10 Mar 2017 03:36:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32846 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755240AbdCJIgH (ORCPT ); Fri, 10 Mar 2017 03:36:07 -0500 Subject: Re: [RFC PATCH 0/4] KVM: Emulate UMIP (or almost do so) To: Yu Zhang References: <1468351223-3250-1-git-send-email-pbonzini@redhat.com> <0543af50-8961-38a7-1acc-aaefd4915dda@redhat.com> <58B68E91.4010400@linux.intel.com> <58C25D7A.7070605@linux.intel.com> Cc: qian.ouyang@intel.com, "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" From: Paolo Bonzini Message-ID: <46eca436-0d57-a514-39e4-7c45e25e493e@redhat.com> Date: Fri, 10 Mar 2017 09:36:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <58C25D7A.7070605@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 10 Mar 2017 08:36:07 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 621 Lines: 18 On 10/03/2017 09:02, Yu Zhang wrote: >> Besides, is this all the test for UMIP unit test? I.e. do we need to >> construct a scenario in the test to trigger vm exit and let hypervisor >> inject a GP fault? - I did not see this scenario in this patch. Or any >> other suggestions? :-) > > Hi Paolo, any suggestions? > Sorry for the disturb. :) Hi, you get the scenario where a vmexit is triggered by the hypervisor if you run the unit test on a machine that lacks UMIP support. We can also add a module parameter to force emulation, so that it will be possible to test UMIP emulation on newer processors too. Paolo