Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932500AbdCJIkx convert rfc822-to-8bit (ORCPT ); Fri, 10 Mar 2017 03:40:53 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:6170 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932424AbdCJIkv (ORCPT ); Fri, 10 Mar 2017 03:40:51 -0500 From: Patrice CHOTARD To: Jisheng Zhang , "adrian.hunter@intel.com" , "ulf.hansson@linaro.org" CC: "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kernel@stlinux.com" Subject: Re: [PATCH 3/3] mmc: sdhci-st: remove unnecessary platform_set_drvdata() call Thread-Topic: [PATCH 3/3] mmc: sdhci-st: remove unnecessary platform_set_drvdata() call Thread-Index: AQHSmU2Uxl3iG0AHek2ggZUftMQ7wqGNsHqA Date: Fri, 10 Mar 2017 08:40:10 +0000 Message-ID: <7e8b38e3-16a3-b00d-b30b-e24aa0f9d85a@st.com> References: <20170310031733.812-1-jszhang@marvell.com> <20170310031733.812-4-jszhang@marvell.com> In-Reply-To: <20170310031733.812-4-jszhang@marvell.com> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.51] Content-Type: text/plain; charset="Windows-1252" Content-ID: <9E5077E27187E349BE43C82B16391CFE@st.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-10_06:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 872 Lines: 29 Hi Jisheng On 03/10/2017 04:17 AM, Jisheng Zhang wrote: > sdhci_pltfm_init() has already set the platform drvdata for us, remove > the unnecessary platform_set_drvdata() call. > > Signed-off-by: Jisheng Zhang > --- > drivers/mmc/host/sdhci-st.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c > index ed92ce729dde..7fff6490855c 100644 > --- a/drivers/mmc/host/sdhci-st.c > +++ b/drivers/mmc/host/sdhci-st.c > @@ -418,8 +418,6 @@ static int sdhci_st_probe(struct platform_device *pdev) > goto err_out; > } > > - platform_set_drvdata(pdev, host); > - > host_version = readw_relaxed((host->ioaddr + SDHCI_HOST_VERSION)); > > dev_info(&pdev->dev, "SDHCI ST Initialised: Host Version: 0x%x Vendor Version 0x%x\n", > Acked-by: Patrice Chotard Thanks