Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933299AbdCJLtG (ORCPT ); Fri, 10 Mar 2017 06:49:06 -0500 Received: from mga06.intel.com ([134.134.136.31]:57663 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933070AbdCJLtD (ORCPT ); Fri, 10 Mar 2017 06:49:03 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,140,1486454400"; d="asc'?scan'208";a="66139423" From: Felipe Balbi To: Romain Izard Cc: linux-usb@vger.kernel.org, LKML , Greg Kroah-Hartman , "# 4 . 9+" Subject: Re: [PATCH v2] usb: gadget: legacy gadgets are optional In-Reply-To: References: <20170309141046.6724-1-romain.izard.pro@gmail.com> <8760jhze53.fsf@linux.intel.com> Date: Fri, 10 Mar 2017 13:47:52 +0200 Message-ID: <87fuilxsif.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2807 Lines: 82 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Romain Izard writes: > Hello Felipe, > > 2017-03-10 10:15 GMT+01:00 Felipe Balbi : >> >> Hi, >> >> Romain Izard writes: >>> With commit "usb: gadget: don't couple configfs to legacy gadgets" >>> it is possible to build a modular kernel with both built-in configfs >>> support and modular legacy gadget drivers. >>> >>> But when building a kernel without modules, it is also necessary to be >>> able to build with configfs but without any legacy gadget driver. >>> >>> Mark the choice for legacy gadget drivers as optional. >>> >>> Fixes: bc49d1d17dcf ("usb: gadget: don't couple configfs to legacy gadg= ets") >>> Cc: # 4.9+ >> >> this is *NOT* a fix since this requirement didn't exist before. > > It worked in 4.1, as a non-modular kernel would only have a single entry > from the USB gadget driver choice option, and USB_CONFIGFS was one of > those. but it wasn't a requirement :-) > When I moved on to 4.9, this configuration could not be selected anymore. you could've let us know you needed that working :-) That changed quite a while back :-) Anyway, I get what you mean. I'll take patch for v4.12 with the stable tag in it. >>> @@ -476,6 +477,12 @@ choice >>> not be able work with that controller, or might need to impleme= nt >>> a less common variant of a device class protocol. >>> >>> + The available choices each represent a single precomposed USB >>> + gadget configuration. In the device model, each option contains >>> + both the device instanciation as a child for a USB gadget >>> + controller, and the relevant drivers for each function declared >>> + by the device. >> >> unrelated change > > I'll split this. thank you =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAljCkmgACgkQzL64meEa mQaAqg//YzWfycw5splZGoE4aeVRjefmZ7fLHHX+D5I1lmyEDlNhGlgIM2iLwo+2 6VUUkRqu9LiT8M8DaOAmdshYUQ1Q09xFro8WnhBe1KHEMeyTxLj63yH5bvWmRYKf ezNp00VJoZWxUpdVsWc+31c3QRTITLwS+oN0X1HsMsrBPUXelsFmOiCNYkGhlKXP HGPZbCEaZQwIrK/pR/YfgByHjOqJqrO/0zMsKfHMVXkE8H+ZRR8RJCKd/cSd+Oul hbcYDAeTuqVa8vmsocCGNiX/VjHxxng6s91GC1/0v7t5BHODpRMbOQmNlb0gyKQ7 yzn1+JdVRb78taaisqhsiJzWraMj/Zy9zVwWdZbkGB45J2pjHP5lb5y/JwF9N46N J/5PHtKXibDFpc2eJDWILazMLOj7MkmnKbYsGhlP6g+rLgSOBtASo/BL6Ki5Vp0j JLBeIz4bl4+qDoO2Lw8plxy+X2f9isoRFr+ypkrIKidlk6OYWSmFBMsjODRgq9Xy P8GaWyj3iEBHzSOftfkpXDQyvVhPupYD06FnvigWpbAi80dgtCN0quQ0v1Ca4bnW xLVzYpgjFN4KXNXl/m2p+TSDZ8W0Nb7vijqVQ3Mo9pRirZpfqhinmDDWzWjDIHMH swMqP+AV4vAzJHlbJWZhqRyhuEJg14o0MlA1EyLpTk+Nl1cF4x8= =c3io -----END PGP SIGNATURE----- --=-=-=--