Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936490AbdCJMKz (ORCPT ); Fri, 10 Mar 2017 07:10:55 -0500 Received: from mail-it0-f67.google.com ([209.85.214.67]:33136 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935996AbdCJMKt (ORCPT ); Fri, 10 Mar 2017 07:10:49 -0500 MIME-Version: 1.0 In-Reply-To: References: From: Geert Uytterhoeven Date: Fri, 10 Mar 2017 13:10:36 +0100 X-Google-Sender-Auth: i45KfS_E5BRR-OkHywX0EN78Ju8 Message-ID: Subject: Re: [PATCH 3.16 125/370] clk: renesas: mstp: Support 8-bit registers for r7s72100 To: Ben Hutchings Cc: "linux-kernel@vger.kernel.org" , stable , Andrew Morton , Chris Brandt , Stephen Boyd , Kuninori Morimoto , Geert Uytterhoeven Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1566 Lines: 42 Hi Ben, On Fri, Mar 10, 2017 at 12:46 PM, Ben Hutchings wrote: > 3.16.42-rc1 review patch. If anyone has any objections, please let me know. No objections, but you also want commit f59de563358eb9351b7f8f0ba2d3be2ebb70b93d Author: Chris Brandt Date: Tue Feb 14 11:08:05 2017 -0500 clk: renesas: mstp: ensure register writes complete > ------------------ > > From: Chris Brandt > > commit e2a33c34ddff22ee208d80abdd12b88a98d6cb60 upstream. > > The RZ/A1 is different than the other Renesas SOCs because the MSTP > registers are 8-bit instead of 32-bit and if you try writing values as > 32-bit nothing happens...meaning this driver never worked for r7s72100. > > Fixes: b6face404f38 ("ARM: shmobile: r7s72100: add essential clock nodes to dtsi") > Signed-off-by: Chris Brandt > Reviewed-by: Geert Uytterhoeven > Tested-by: Geert Uytterhoeven > Acked-by: Kuninori Morimoto > Signed-off-by: Stephen Boyd > [bwh: Backported to 3.16: adjust filename] > Signed-off-by: Ben Hutchings Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds