Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937014AbdCJNRt (ORCPT ); Fri, 10 Mar 2017 08:17:49 -0500 Received: from mail-wr0-f174.google.com ([209.85.128.174]:33679 "EHLO mail-wr0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933999AbdCJNRq (ORCPT ); Fri, 10 Mar 2017 08:17:46 -0500 Subject: Re: [PATCH v6 2/2] backlight arcxcnn devicetree bindings for ArcticSand To: Olimpiu Dejeu , robh@kernel.org References: <1488306035-16461-1-git-send-email-olimpiu@arcticsand.com> Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org, jingoohan1@gmail.com, bdodge@arcticsand.com, joe@perches.com, medasaro@arcticsand.com From: Daniel Thompson Message-ID: <73fb917e-d71c-b094-7d33-8ccddd0ea1cf@linaro.org> Date: Fri, 10 Mar 2017 14:17:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1488306035-16461-1-git-send-email-olimpiu@arcticsand.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2548 Lines: 71 On 28/02/17 19:20, Olimpiu Dejeu wrote: > backlight: Add devicetree bindings for the Arctic Sand backlight driver > This patch provides devicetree bindings for the Arctic Sand > driver submitted in the previous patch > Acked-by: Rob Herring > Signed-off-by: Olimpiu Dejeu Acked-by: Daniel Thompson But... This binding documentation patch should precede the code in the patch series (amoung other things this avoids transient checkpatch errors). > --- > v5 => v6: > - Version updated to match other patch in set. No other changes. > v4 => v5: > - Added spaces for increased readability per Lee Jones > v3 => v4: > - Added spaces for increased readability per Lee Jones > v2 => v3: > - Version updated to match other patch in set. No other changes. > v1 => v2: > - Version updated to match other patch in set. No other changes. > > .../bindings/leds/backlight/arcxcnn_bl.txt | 33 ++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt > > diff --git a/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt > new file mode 100644 > index 0000000..ecb7731 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt > @@ -0,0 +1,33 @@ > +Binding for ArcticSand arc2c0608 LED driver > + > +Required properties: > +- compatible: should be "arc,arc2c0608" > +- reg: slave address > + > +Optional properties: > +- default-brightness: brightness value on boot, value from: 0-4095 > +- label: The name of the backlight device > + See Documentation/devicetree/bindings/leds/common.txt > +- led-sources: List of enabled channels from 0 to 5. > + See Documentation/devicetree/bindings/leds/common.txt > + > +- arc,led-config-0: setting for register ILED_CONFIG_0 > +- arc,led-config-1: setting for register ILED_CONFIG_1 > +- arc,dim-freq: PWM mode frequence setting (bits [3:0] used) > +- arc,comp-config: setting for register CONFIG_COMP > +- arc,filter-config: setting for register FILTER_CONFIG > +- arc,trim-config: setting for register IMAXTUNE > + > +Note: Optional properties not specified will default to values in IC EPROM > + > +Example: > + > +arc2c0608@30 { > + compatible = "arc,arc2c0608"; > + reg = <0x30>; > + default-brightness = <500>; > + label = "lcd-backlight"; > + linux,default-trigger = "backlight"; > + led-sources = <0 1 2 5>; > +}; > + >