Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932985AbdCJR7i (ORCPT ); Fri, 10 Mar 2017 12:59:38 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:37932 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932683AbdCJR71 (ORCPT ); Fri, 10 Mar 2017 12:59:27 -0500 Subject: Re: [PATCH v3 2/2] usb: gadget: reword configuration choices To: Romain Izard , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Felipe Balbi , Greg Kroah-Hartman References: <20170310131142.28816-1-romain.izard.pro@gmail.com> <20170310131142.28816-3-romain.izard.pro@gmail.com> From: Randy Dunlap Message-ID: Date: Fri, 10 Mar 2017 09:59:23 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170310131142.28816-3-romain.izard.pro@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2277 Lines: 64 On 03/10/17 05:11, Romain Izard wrote: > As USB_CONFIGFS is not a part of the "USB Gadget Drivers" choice > anymore, the name for the option and its attached description needs to > be more descriptive. It appears one level higher in the configuration > menu, and without the context provided by the comments for the choice > entry, it needs to make sense on its own. > > Conversely, the "USB Gadget Drivers" entry now only introduces the > legacy drivers, where one or more functions are combined in a single > driver. As the configfs option can be used as a full-fledged > alternative, rename the choice entry to show that it is not the only > way to provice service as an USB gadget. > > Signed-off-by: Romain Izard > --- > Changes in v3: > - split from the functional patch > > drivers/usb/gadget/Kconfig | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig > index f3ee80ece682..e157e9aa4f3d 100644 > --- a/drivers/usb/gadget/Kconfig > +++ b/drivers/usb/gadget/Kconfig > @@ -212,7 +212,7 @@ config USB_F_TCM > # this first set of drivers all depend on bulk-capable hardware. > > config USB_CONFIGFS > - tristate "USB functions configurable through configfs" > + tristate "USB Gadget functions configurable through configfs" > select USB_LIBCOMPOSITE > help > A Linux USB "gadget" can be set up through configfs. > @@ -458,7 +458,7 @@ config USB_CONFIGFS_F_TCM > UAS utilizes the USB 3.0 feature called streams support. > > choice > - tristate "USB Gadget Drivers" > + tristate "USB Gadget precomposed configurations" > default USB_ETH > optional > help > @@ -477,6 +477,12 @@ choice > not be able work with that controller, or might need to implement > a less common variant of a device class protocol. > > + The available choices each represent a single precomposed USB > + gadget configuration. In the device model, each option contains > + both the device instanciation as a child for a USB gadget instantiation > + controller, and the relevant drivers for each function declared > + by the device. > + > source "drivers/usb/gadget/legacy/Kconfig" > > endchoice > -- ~Randy