Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933630AbdCJSYX (ORCPT ); Fri, 10 Mar 2017 13:24:23 -0500 Received: from mga11.intel.com ([192.55.52.93]:54976 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932681AbdCJSYQ (ORCPT ); Fri, 10 Mar 2017 13:24:16 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,142,1486454400"; d="scan'208";a="75213329" Date: Fri, 10 Mar 2017 10:25:13 -0800 (PST) From: Shivappa Vikas X-X-Sender: vikas@vshiva-Udesk To: Thomas Gleixner cc: Shivappa Vikas , vikas.shivappa@intel.com, linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com, mingo@kernel.org, peterz@infradead.org, ravi.v.shankar@intel.com, tony.luck@intel.com, fenghua.yu@intel.com, andi.kleen@intel.com Subject: Re: [PATCH 2/5] x86/intel_rdt: Improvements to parsing schemata In-Reply-To: Message-ID: References: <1487360328-6768-1-git-send-email-vikas.shivappa@linux.intel.com> <1487360328-6768-3-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1231 Lines: 47 On Fri, 10 Mar 2017, Thomas Gleixner wrote: > On Thu, 9 Mar 2017, Shivappa Vikas wrote: > >> >>> Anyway, first of all we want to know WHY this ordering is required. If it's >>> not required then why would we enforce it? >> >> Do the users want to see the data in the same order they entered ? If we want >> to do that then its easy to implement when we enforce the order .. (because >> right now resources are always displayed in a predefined order). >> Otherwise i can drop this patch. > > It's fine to display them in a defined order, but there is no point to > enforce the ordering on write. > > The real question here is whether we really have to write every line on > every update. IMO it's sufficient to write a single resource line and not > require to update all resources every time. Ok in that case we can drop this. because my thought was that user wants to see the contents he wrote when he overwrites the whole file like below , IOW its wierd for user to do # echo "L3:0=0xff;1=0xf0" > /sys/fs/resctrl/schemata then # cat /sys/fs/resctrl/schemata L3:0=0xff;1=0xf0 L2:0=0xff;1=0xf0 MB:.... But he did not write the L2,MB when he did an overwrite of the whole file. Thanks, Vikas > > Thanks, > > tglx > > >