Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933676AbdCJVVe (ORCPT ); Fri, 10 Mar 2017 16:21:34 -0500 Received: from gateway32.websitewelcome.com ([192.185.145.113]:41483 "EHLO gateway32.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932372AbdCJVVZ (ORCPT ); Fri, 10 Mar 2017 16:21:25 -0500 Date: Fri, 10 Mar 2017 15:20:37 -0600 Message-ID: <20170310152037.Horde.49bdIvAhaWSa41VTBWvs3xO@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: Felipe Balbi Cc: Michal Nazarewicz , Andy Shevchenko , gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com, mail@iagoabal.eu, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Senna Tschudin Subject: Re: [PATCH v3] usb: gadget: udc: remove pointer dereference after free References: <20170208191549.GA3998@embeddedgus> <1486582639.2133.412.camel@linux.intel.com> <20170208153322.Horde.mdD6qAMhN7aTL6u10JtoBcQ@gator4166.hostgator.com> <20170211110731.Horde.BPRpngvnMPXYcqid3jyhoJ-@gator4166.hostgator.com> <20170213225051.Horde.FuA7hX2Mg68zi7e218F_3so@gator4166.hostgator.com> <20170213225317.Horde.AFw31ZzUy8_Xlb1EKAA_9Ci@gator4166.hostgator.com> <87o9x9xt29.fsf@linux.intel.com> In-Reply-To: <87o9x9xt29.fsf@linux.intel.com> User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Exim-ID: 1cmRxl-000TV5-HY X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:41846 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 3 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1014 Lines: 43 Hello, Quoting Felipe Balbi : > "Gustavo A. R. Silva" writes: > >> Remove pointer dereference after free. >> >> Addresses-Coverity-ID: 1091173 >> Acked-by: Michal Nazarewicz >> Signed-off-by: Gustavo A. R. Silva >> --- >> Changes in v2: >> Move pointer dereference before pci_pool_free() >> Set pointer to NULL after free >> >> Changes in v3: >> Remove 'td->next = 0x00' inside for loop. >> Remove unnecessary pointer nullification after free. >> >> drivers/usb/gadget/udc/pch_udc.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/usb/gadget/udc/pch_udc.c >> b/drivers/usb/gadget/udc/pch_udc.c >> index a97da64..8a365aa 100644 >> --- a/drivers/usb/gadget/udc/pch_udc.c >> +++ b/drivers/usb/gadget/udc/pch_udc.c >> @@ -1523,7 +1523,6 @@ static void pch_udc_free_dma_chain(struct >> pch_udc_dev *dev, > > line wrapped. Can't apply. > I'll fix it right away. Thanks -- Gustavo A. R. Silva