Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933029AbdCKAFN (ORCPT ); Fri, 10 Mar 2017 19:05:13 -0500 Received: from mail-io0-f195.google.com ([209.85.223.195]:33243 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755330AbdCKAFE (ORCPT ); Fri, 10 Mar 2017 19:05:04 -0500 Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: le16_to_cpu for xattr->e_value_size To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Kinglong Mee References: <20170310175335.26013-1-jaegeuk@kernel.org> From: Kinglong Mee Message-ID: Date: Sat, 11 Mar 2017 08:04:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170310175335.26013-1-jaegeuk@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 953 Lines: 28 On 3/11/2017 01:53, Jaegeuk Kim wrote: > This patch fixes missing le16 conversion, reported by kbuild test robot. > > Fixes: 5f35a2cd5 ("f2fs: Don't update the xattr data that same as the exist") > Signed-off-by: Jaegeuk Kim Reviewed-by: Kinglong Mee > --- > fs/f2fs/xattr.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c > index 7298a4488f7f..aff7619e3f96 100644 > --- a/fs/f2fs/xattr.c > +++ b/fs/f2fs/xattr.c > @@ -546,7 +546,9 @@ static bool f2fs_xattr_value_same(struct f2fs_xattr_entry *entry, > const void *value, size_t size) > { > void *pval = entry->e_name + entry->e_name_len; > - return (entry->e_value_size == size) && !memcmp(pval, value, size); > + > + return (le16_to_cpu(entry->e_value_size) == size) && > + !memcmp(pval, value, size); > } > > static int __f2fs_setxattr(struct inode *inode, int index, >