Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933214AbdCKOyu (ORCPT ); Sat, 11 Mar 2017 09:54:50 -0500 Received: from mail-it0-f67.google.com ([209.85.214.67]:33152 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753168AbdCKOyl (ORCPT ); Sat, 11 Mar 2017 09:54:41 -0500 Message-ID: <1489244077.1857.2.camel@kepstin.ca> Subject: Re: [PATCH v3 0/3] Bind RMI4 over SMBus from PS/2 From: Calvin Walton To: Benjamin Tissoires , Dmitry Torokhov , Andrew Duggan Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Date: Sat, 11 Mar 2017 09:54:37 -0500 In-Reply-To: <20170308152445.12082-1-benjamin.tissoires@redhat.com> References: <20170308152445.12082-1-benjamin.tissoires@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.5 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2355 Lines: 45 Hi, On Wed, 2017-03-08 at 16:24 +0100, Benjamin Tissoires wrote: > Hi Dmitry, > > This is mostly a resend of the PS/2-SMBus binding (last 3 patches of > now 3 years > of trial and errors). > I integrated both warnings raised by Coccinelle, and squashed 4/3 > into 3/3. Just want to provide you some quick feedback from the user's perspective... I tested this patch set on my somewhat hacked together laptop - I have a Lenovo T440p with the touchpad replaced with a "top button pad" from a T450 or similar. With this patch set (and using the psmouse.synaptics_intertouch=1 option), the touchpad is found and used via RMI4/SMBUS, and the PS2 passthrough to the trackpoint does work. Passing the buttons presses from the top buttons to the trackpoint device doesn't work - my understanding is the code for this isn't included here? The touchpad cursor movement (and scrolling, etc.) is so much smoother than with the PS2 interface of this touchpad model... I'm glad these patches are getting closer to complete! Calvin. [   17.665070] psmouse serio1: synaptics: queried max coordinates: x [..5676], y [..4758] [   17.698107] psmouse serio1: synaptics: queried min coordinates: x [1266..], y [1096..] [   17.760612] psmouse serio1: synaptics: Touchpad model: 1, fw: 8.1, id: 0x1e2b1, caps: 0xf003a3/0x943300/0x12e800/0x10000, board id: 3053, fw id: 2560 [   17.763619] psmouse serio1: synaptics: serio: Synaptics pass-through port at isa0060/serio1/input0 [   17.766577] psmouse serio1: synaptics: device also supported by an other bus. [   17.807548] input: SynPS/2 Synaptics TouchPad as /devices/platform/i8042/serio1/input/input9 [   18.435205] psmouse serio2: trackpoint: IBM TrackPoint firmware: 0x0e, buttons: 3/3 [   18.630809] input: TPPS/2 IBM TrackPoint as /devices/platform/i8042/serio1/serio2/input/input18 [   19.064659] rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics, product: TM3053-003, fw id: 1741108 [   19.131839] input: Synaptics TM3053-003 as /devices/rmi4-00/input/input19 [   19.152671] rmi4_smbus 9-002c: registered rmi smb driver at 0x2c. [   20.425233] psmouse serio3: trackpoint: IBM TrackPoint firmware: 0x0e, buttons: 3/3 [   20.482937] input: TPPS/2 IBM TrackPoint as /devices/rmi4-00/rmi4-00.fn03/serio3/input/input21 -- Calvin Walton