Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933942AbdCLJTD (ORCPT ); Sun, 12 Mar 2017 05:19:03 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:58910 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933758AbdCLJS6 (ORCPT ); Sun, 12 Mar 2017 05:18:58 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 771C060CDD Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vivek.gautam@codeaurora.org MIME-Version: 1.0 In-Reply-To: <58C142F6.2030708@ti.com> References: <20170309113311.15345-1-jh80.chung@samsung.com> <58C142F6.2030708@ti.com> From: Vivek Gautam Date: Sun, 12 Mar 2017 14:48:54 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH] phy: samsung: move the Samsung specific phy files to "samsung" directory To: Kishon Vijay Abraham I Cc: Jaehoon Chung , "linux-kernel@vger.kernel.org" , Kukjin Kim , krzk@kernel.org, kamil@wypas.org, Sylwester Nawrocki , javier@osg.samsung.com, inux-samsung-soc@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2982 Lines: 72 Hi Kishon, On Thu, Mar 9, 2017 at 5:26 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Thursday 09 March 2017 05:03 PM, Jaehoon Chung wrote: >> Make the "samsung" directory and move the Samsung specific files to >> there for maintaining the files relevant to Samsung. > > The number of phy drivers in drivers/phy is getting unmanageable. I think this > is a good step to make it a little better. Can you also add a MAINTAINER for > drivers/phy/samsung? I remember making a similar attempt in past [1], but that time we couldn't reach an agreement as to whether group the phy drivers based on vendors or based on the type of phy. If you are fine with grouping the drivers for each vendor, I hope you can consider picking that patch (I can respin the patch based on linux-phy/next). Other driver maintainers were also cool with that older patch. Let me know your comments. [1] https://patchwork.kernel.org/patch/8762561/ Regards Vivek > > Thanks > Kishon >> >> Signed-off-by: Jaehoon Chung >> --- >> drivers/phy/Kconfig | 96 +---------------------- >> drivers/phy/Makefile | 14 +--- >> drivers/phy/samsung/Kconfig | 92 ++++++++++++++++++++++ >> drivers/phy/samsung/Makefile | 11 +++ >> drivers/phy/{ => samsung}/phy-exynos-dp-video.c | 0 >> drivers/phy/{ => samsung}/phy-exynos-mipi-video.c | 0 >> drivers/phy/{ => samsung}/phy-exynos-pcie.c | 0 >> drivers/phy/{ => samsung}/phy-exynos4210-usb2.c | 0 >> drivers/phy/{ => samsung}/phy-exynos4x12-usb2.c | 0 >> drivers/phy/{ => samsung}/phy-exynos5-usbdrd.c | 0 >> drivers/phy/{ => samsung}/phy-exynos5250-sata.c | 0 >> drivers/phy/{ => samsung}/phy-exynos5250-usb2.c | 0 >> drivers/phy/{ => samsung}/phy-s5pv210-usb2.c | 0 >> drivers/phy/{ => samsung}/phy-samsung-usb2.c | 0 >> drivers/phy/{ => samsung}/phy-samsung-usb2.h | 0 >> 15 files changed, 108 insertions(+), 105 deletions(-) >> create mode 100644 drivers/phy/samsung/Kconfig >> create mode 100644 drivers/phy/samsung/Makefile >> rename drivers/phy/{ => samsung}/phy-exynos-dp-video.c (100%) >> rename drivers/phy/{ => samsung}/phy-exynos-mipi-video.c (100%) >> rename drivers/phy/{ => samsung}/phy-exynos-pcie.c (100%) >> rename drivers/phy/{ => samsung}/phy-exynos4210-usb2.c (100%) >> rename drivers/phy/{ => samsung}/phy-exynos4x12-usb2.c (100%) >> rename drivers/phy/{ => samsung}/phy-exynos5-usbdrd.c (100%) >> rename drivers/phy/{ => samsung}/phy-exynos5250-sata.c (100%) >> rename drivers/phy/{ => samsung}/phy-exynos5250-usb2.c (100%) >> rename drivers/phy/{ => samsung}/phy-s5pv210-usb2.c (100%) >> rename drivers/phy/{ => samsung}/phy-samsung-usb2.c (100%) >> rename drivers/phy/{ => samsung}/phy-samsung-usb2.h (100%) [snip] -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project