Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933237AbdCLJsR (ORCPT ); Sun, 12 Mar 2017 05:48:17 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:18674 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755303AbdCLJsH (ORCPT ); Sun, 12 Mar 2017 05:48:07 -0400 Subject: Re: [PATCH] um: use KERN_CONT in stack dump To: Richard Weinberger References: <20170312093820.12044-1-vegard.nossum@oracle.com> Cc: user-mode-linux-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org From: Vegard Nossum Message-ID: <005a0edf-6d5e-e9c0-6f93-3d08a41cb24a@oracle.com> Date: Sun, 12 Mar 2017 10:47:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 928 Lines: 32 On 12/03/2017 10:45, Richard Weinberger wrote: > Am 12.03.2017 um 10:38 schrieb Vegard Nossum: >> Without KERN_CONT, the symbol will appear on a new line, making stack >> traces completely unreadable: [snip] > I think it is better to fix the root of the problem by using a single printk. > i.e. > > diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c > index aa1b56f5ac68..18eddf677ec6 100644 > --- a/arch/um/kernel/sysrq.c > +++ b/arch/um/kernel/sysrq.c > @@ -17,10 +17,8 @@ > > static void _print_addr(void *data, unsigned long address, int reliable) > { > - pr_info(" [<%08lx>]", address); > - pr_cont(" %s", reliable ? "" : "? "); > - print_symbol("%s", address); > - pr_cont("\n"); > + pr_info(" [<%08lx>] %s%pB\n", address, reliable ? "" : "? ", > + (void *)address); > } Your patch is better. Tested-by: Vegard Nossum Thanks, Vegard