Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932803AbdCLKXM (ORCPT ); Sun, 12 Mar 2017 06:23:12 -0400 Received: from mga03.intel.com ([134.134.136.65]:38559 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755667AbdCLKXD (ORCPT ); Sun, 12 Mar 2017 06:23:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,152,1486454400"; d="scan'208";a="75642583" From: Tomas Winkler To: James Bottomley , "Martin K . Petersen" , Vinayak Holikatti Cc: Christoph Hellwig , Yaniv Gardi , Subhash Jadavani , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Tomas Winkler Subject: [scsi] scsi: ufs: don't check unsigned type for a negative value Date: Sun, 12 Mar 2017 12:22:02 +0200 Message-Id: <20170312102202.9889-1-tomas.winkler@intel.com> X-Mailer: git-send-email 2.9.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 817 Lines: 26 Fix compilation warning drivers/scsi/ufs/ufshcd.c:7645:13: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] if ((value < UFS_PM_LVL_0) || (value >= UFS_PM_LVL_MAX)) Signed-off-by: Tomas Winkler --- drivers/scsi/ufs/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 1359913bf840..e8c26e6e6237 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -7642,7 +7642,7 @@ static inline ssize_t ufshcd_pm_lvl_store(struct device *dev, if (kstrtoul(buf, 0, &value)) return -EINVAL; - if ((value < UFS_PM_LVL_0) || (value >= UFS_PM_LVL_MAX)) + if (value >= UFS_PM_LVL_MAX) return -EINVAL; spin_lock_irqsave(hba->host->host_lock, flags); -- 2.9.3