Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934139AbdCLNhu (ORCPT ); Sun, 12 Mar 2017 09:37:50 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45466 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933265AbdCLNhl (ORCPT ); Sun, 12 Mar 2017 09:37:41 -0400 Date: Sun, 12 Mar 2017 14:37:22 +0100 From: Greg KH To: Craig Inches Cc: oleg.drokin@intel.com, andreas.dilger@intel.com, jsimmons@infradead.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, lustre-devel@lists.lustre.org Subject: Re: [PATCH] staging: lustre fix constant comparision style issue in lu_object.h Message-ID: <20170312133722.GC27791@kroah.com> References: <20170311130740.11488-1-Craig@craiginches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170311130740.11488-1-Craig@craiginches.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 297 Lines: 10 On Sat, Mar 11, 2017 at 01:07:40PM +0000, Craig Inches wrote: > This patch resolves the "Comparisons should place the constant on > the right side of the test" found with checkpatch tool. Both are constants, I think checkpatch is the thing that is wrong here, don't you agree? thanks, greg k-h