Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933858AbdCLOLM (ORCPT ); Sun, 12 Mar 2017 10:11:12 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:33253 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755744AbdCLOLG (ORCPT ); Sun, 12 Mar 2017 10:11:06 -0400 Date: Sun, 12 Mar 2017 09:11:02 -0500 From: Rob Herring To: Ryan Lee Cc: lgirdwood@gmail.com, broonie@kernel.org, mark.rutland@arm.com, perex@perex.cz, tiwai@suse.com, arnd@arndb.de, michael@amarulasolutions.com, oder_chiou@realtek.com, yesanishhere@gmail.com, jacob@teenage.engineering, Damien.Horsley@imgtec.com, bardliao@realtek.com, kuninori.morimoto.gx@renesas.com, petr@barix.com, lars@metafoo.de, nh6z@nh6z.net, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 01/10] ALSA SoC MAX98927 driver - Initial release Message-ID: <20170312141102.fxigzia2nvfuli2d@rob-hp-laptop> References: <1488552768-14901-1-git-send-email-ryans.lee@maximintegrated.com> <1488552768-14901-2-git-send-email-ryans.lee@maximintegrated.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488552768-14901-2-git-send-email-ryans.lee@maximintegrated.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1025 Lines: 27 On Fri, Mar 03, 2017 at 11:52:39PM +0900, Ryan Lee wrote: > From: Ryan Lee > > Signed-off-by: Ryan Lee > --- > > Initial release of ALSA SoC MAX98927 driver. > > .../devicetree/bindings/sound/max98927.txt | 32 + In addition to what Mark said, please split bindings to a separate patch. > sound/soc/codecs/Kconfig | 5 + > sound/soc/codecs/Makefile | 2 + > sound/soc/codecs/max98927.c | 954 +++++++++++++++ > sound/soc/codecs/max98927.h | 1253 ++++++++++++++++++++ > 5 files changed, 2246 insertions(+) > create mode 100755 Documentation/devicetree/bindings/sound/max98927.txt > mode change 100644 => 100755 sound/soc/codecs/Kconfig > mode change 100644 => 100755 sound/soc/codecs/Makefile > create mode 100755 sound/soc/codecs/max98927.c > create mode 100755 sound/soc/codecs/max98927.h These files should not be executable. Rob