Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934162AbdCLOdX (ORCPT ); Sun, 12 Mar 2017 10:33:23 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34680 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934029AbdCLOdP (ORCPT ); Sun, 12 Mar 2017 10:33:15 -0400 Date: Sun, 12 Mar 2017 09:33:12 -0500 From: Rob Herring To: Enric Balletbo i Serra Cc: Peter Huewe , Mark Rutland , Jarkko Sakkinen , Jason Gunthorpe , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net, Sonny Rao Subject: Re: [PATCH v3] tpm: do not suspend/resume if power stays on Message-ID: <20170312143312.hrkzl76ztwsay2lw@rob-hp-laptop> References: <20170303160959.27422-1-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170303160959.27422-1-enric.balletbo@collabora.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1162 Lines: 29 On Fri, Mar 03, 2017 at 05:09:59PM +0100, Enric Balletbo i Serra wrote: > From: Sonny Rao > > The suspend/resume behavior of the TPM can be controlled by setting > "powered-while-suspended" in the DTS. This is useful for the cases > when hardware does not power-off the TPM. > > Signed-off-by: Sonny Rao > Signed-off-by: Enric Balletbo i Serra > --- > Changes since v2: > Jarkko Sakkinen > - Add a new TPM_CHIP_FLAG_ALWAYS_POWERED flag instead of using a boolean variable. > - Remove a trailing newline. > Changes since v1: > Jason Gunthorpe : > - Move the code to handle suspend/resume in the common chip code. > > Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt | 6 ++++++ I would say this shouldn't be TPM specific, but looks like we already have a dts with this, so: Acked-by: Rob Herring > drivers/char/tpm/tpm-interface.c | 3 +++ > drivers/char/tpm/tpm.h | 1 + > drivers/char/tpm/tpm_of.c | 3 +++ > 4 files changed, 13 insertions(+)