Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750782AbdCMD6i (ORCPT ); Sun, 12 Mar 2017 23:58:38 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:33032 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750714AbdCMD6h (ORCPT ); Sun, 12 Mar 2017 23:58:37 -0400 MIME-Version: 1.0 In-Reply-To: <20170312183304.GB7728@d830.WORKGROUP> References: <20170312133250.GA7772@singhal-Inspiron-5558> <20170312183304.GB7728@d830.WORKGROUP> From: SIMRAN SINGHAL Date: Mon, 13 Mar 2017 09:28:34 +0530 Message-ID: Subject: Re: [Outreachy kernel] [PATCH] staging: iio: ade7753: replace mlock with driver private lock To: Alison Schofield Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Pete Meerwald-Stadler , Greg Kroah-Hartman , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3044 Lines: 75 On Mon, Mar 13, 2017 at 12:03 AM, Alison Schofield wrote: > On Sun, Mar 12, 2017 at 07:02:50PM +0530, simran singhal wrote: >> The IIO subsystem is redefining iio_dev->mlock to be used by >> the IIO core only for protecting device operating mode changes. >> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. >> >> In this driver, mlock was being used to protect hardware state >> changes. Replace it with a lock in the devices global data. >> >> Fix some coding style issues related to white space also. >> >> Signed-off-by: simran singhal > > Hi Simran, This looks good to me. Let's see what the > reviewers say. I think the white space stuff is ok, > since it was right where you were editing. > alisons > Alison, so sending this patch here on outreachy mailing list is fine. Still confuse :P >> --- >> drivers/staging/iio/meter/ade7753.c | 14 ++++++++------ >> 1 file changed, 8 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/staging/iio/meter/ade7753.c b/drivers/staging/iio/meter/ade7753.c >> index dfd8b71..ca99d82 100644 >> --- a/drivers/staging/iio/meter/ade7753.c >> +++ b/drivers/staging/iio/meter/ade7753.c >> @@ -81,12 +81,14 @@ >> * @tx: transmit buffer >> * @rx: receive buffer >> * @buf_lock: mutex to protect tx and rx >> + * @lock: protect sensor state >> **/ >> struct ade7753_state { >> - struct spi_device *us; >> - struct mutex buf_lock; >> - u8 tx[ADE7753_MAX_TX] ____cacheline_aligned; >> - u8 rx[ADE7753_MAX_RX]; >> + struct spi_device *us; >> + struct mutex buf_lock; >> + struct mutex lock; /* protect sensor state */ >> + u8 tx[ADE7753_MAX_TX] ____cacheline_aligned; >> + u8 rx[ADE7753_MAX_RX]; >> }; >> >> static int ade7753_spi_write_reg_8(struct device *dev, >> @@ -484,7 +486,7 @@ static ssize_t ade7753_write_frequency(struct device *dev, >> if (!val) >> return -EINVAL; >> >> - mutex_lock(&indio_dev->mlock); >> + mutex_lock(&st->lock); >> >> t = 27900 / val; >> if (t > 0) >> @@ -505,7 +507,7 @@ static ssize_t ade7753_write_frequency(struct device *dev, >> ret = ade7753_spi_write_reg_16(dev, ADE7753_MODE, reg); >> >> out: >> - mutex_unlock(&indio_dev->mlock); >> + mutex_unlock(&st->lock); >> >> return ret ? ret : len; >> } >> -- >> 2.7.4 >> >> -- >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. >> To post to this group, send email to outreachy-kernel@googlegroups.com. >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170312133250.GA7772%40singhal-Inspiron-5558. >> For more options, visit https://groups.google.com/d/optout.