Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750993AbdCMGYc (ORCPT ); Mon, 13 Mar 2017 02:24:32 -0400 Received: from out0-153.mail.aliyun.com ([140.205.0.153]:57769 "EHLO out0-153.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760AbdCMGY1 (ORCPT ); Mon, 13 Mar 2017 02:24:27 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R441e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e02c03298;MF=hillf.zj@alibaba-inc.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---.7naOvH9_1489386192; Reply-To: "Hillf Danton" From: "Hillf Danton" To: "'Minchan Kim'" , "'Andrew Morton'" Cc: , , , "'Johannes Weiner'" , "'Michal Hocko'" , "'Kirill A. Shutemov'" , "'Anshuman Khandual'" References: <1489365353-28205-1-git-send-email-minchan@kernel.org> <1489365353-28205-2-git-send-email-minchan@kernel.org> In-Reply-To: <1489365353-28205-2-git-send-email-minchan@kernel.org> Subject: Re: [PATCH v1 01/10] mm: remove unncessary ret in page_referenced Date: Mon, 13 Mar 2017 14:23:12 +0800 Message-ID: <099101d29bc2$4aef6790$e0ce36b0$@alibaba-inc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQIV+DCgOBhRPgQllZDFzchoeA2H3wDJy07BoQVFFaA= Content-Language: zh-cn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 947 Lines: 37 On March 13, 2017 8:36 AM Minchan Kim wrote: > > Anyone doesn't use ret variable. Remove it. > > Acked-by: Kirill A. Shutemov > Signed-off-by: Minchan Kim > --- Acked-by: Hillf Danton > mm/rmap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/rmap.c b/mm/rmap.c > index 7d24bb9..9dbfa6f 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -807,7 +807,6 @@ int page_referenced(struct page *page, > struct mem_cgroup *memcg, > unsigned long *vm_flags) > { > - int ret; > int we_locked = 0; > struct page_referenced_arg pra = { > .mapcount = total_mapcount(page), > @@ -841,7 +840,7 @@ int page_referenced(struct page *page, > rwc.invalid_vma = invalid_page_referenced_vma; > } > > - ret = rmap_walk(page, &rwc); > + rmap_walk(page, &rwc); > *vm_flags = pra.vm_flags; > > if (we_locked) > -- > 2.7.4