Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751707AbdCMHfJ (ORCPT <rfc822;w@1wt.eu>);
        Mon, 13 Mar 2017 03:35:09 -0400
Received: from mail-qt0-f177.google.com ([209.85.216.177]:35235 "EHLO
        mail-qt0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751655AbdCMHfA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 13 Mar 2017 03:35:00 -0400
MIME-Version: 1.0
In-Reply-To: <CAEac7tZv+qLpqwcpCTERiHkUtYVXHd_BoErD_a82KYU=7i04Mw@mail.gmail.com>
References: <1489010090-18025-1-git-send-email-roy.pledge@nxp.com> <CAEac7tZv+qLpqwcpCTERiHkUtYVXHd_BoErD_a82KYU=7i04Mw@mail.gmail.com>
From: Stuart Yoder <stuyoder@gmail.com>
Date: Mon, 13 Mar 2017 02:34:53 -0500
Message-ID: <CAEac7tbzT+WCzUM7cMQhKn7QD1Sf3uyC94YtCSr4m_B_YFaNYw@mail.gmail.com>
Subject: Re: [v6 0/8] staging: fsl-mc: add dpio driver
To: Roy Pledge <roy.pledge@nxp.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, agraf@suse.de, arnd@arndb.de,
        leoyang.li@nxp.com, ioana.ciornei@nxp.com, catalin.horghidan@nxp.com,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>, ruxandra.radulescu@nxp.com
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1421
Lines: 32

>
> This patch series adds the driver for the DPIO object which is a step
> to addressing the final item in the staging TODO list-- adding a
> functional driver on top of the bus driver.  The DPIO driver is a
> dependency for other functional drivers such as Ethernet.
>
> An overview of the DPIO object and driver components are in patch 1.
> Patches 2-6 are internal components of the DPIO driver-- bit twiddling
> of hardware registers, DPAA2 data structures, and the queuing APIs
> exposed to other drivers.
>
> Patch 7 adds the fsl-mc driver for the DPIO object.  It provides the
> probe/remove functions, demonstrating a working example of how fsl-mc
> drivers initialize, interact with the management complex hardware, map
> their mappable MMIO regions, initialize interrupts, register an ISR,
> etc.  All other DPAA2 drivers will follow a similar initialization
> pattern.
>
> version 6 changes
>    -fixed error in size of SG_SHORT_LEN_MASK
>    -removed improper padding in DPIO command responses
>    -fixed some minor checkpatch warnings

Roy, when you re-spin this series please add information below the "---"
on each patch that changed identifying what changed in the patch.   For
example, be specific about which patches were affected by checkpatch and
what fixes you made.  Right now I can't tell.
For an example, of what I'm talking about look at previous versions of
this patch series.

Thanks,
Stuart