Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751446AbdCMHhx (ORCPT ); Mon, 13 Mar 2017 03:37:53 -0400 Received: from mx2.suse.de ([195.135.220.15]:33680 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750902AbdCMHhr (ORCPT ); Mon, 13 Mar 2017 03:37:47 -0400 Subject: Re: [PATCH v2 10/21] x86/xen: split off smp_hvm.c To: Vitaly Kuznetsov , xen-devel@lists.xenproject.org References: <20170302175357.8222-1-vkuznets@redhat.com> <20170302175357.8222-11-vkuznets@redhat.com> Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Boris Ostrovsky , Andrew Jones From: Juergen Gross Message-ID: <9479bcbf-da2a-fa4f-915d-5c0ef50ab1d3@suse.com> Date: Mon, 13 Mar 2017 08:37:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170302175357.8222-11-vkuznets@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1504 Lines: 40 On 02/03/17 18:53, Vitaly Kuznetsov wrote: > Move PVHVM related code to smp_hvm.c. Drop 'static' qualifier from > xen_smp_send_reschedule(), xen_smp_send_call_function_ipi(), > xen_smp_send_call_function_single_ipi(), these functions will be moved to > common smp code when smp_pv.c is split. > > Signed-off-by: Vitaly Kuznetsov One nit below, with this addressed: Reviewed-by: Juergen Gross > --- > arch/x86/xen/Kconfig | 4 ++++ > arch/x86/xen/Makefile | 1 + > arch/x86/xen/smp.c | 57 +++---------------------------------------------- > arch/x86/xen/smp.h | 3 +++ > arch/x86/xen/smp_hvm.c | 58 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 69 insertions(+), 54 deletions(-) > create mode 100644 arch/x86/xen/smp_hvm.c > > diff --git a/arch/x86/xen/smp.h b/arch/x86/xen/smp.h > index a059adb..bf36e79 100644 > --- a/arch/x86/xen/smp.h > +++ b/arch/x86/xen/smp.h > @@ -14,6 +14,9 @@ extern void xen_smp_intr_free(unsigned int cpu); > extern int xen_smp_intr_init_pv(unsigned int cpu); > extern void xen_smp_intr_free_pv(unsigned int cpu); > > +extern void xen_smp_send_reschedule(int cpu); > +extern void xen_smp_send_call_function_ipi(const struct cpumask *mask); > +extern void xen_smp_send_call_function_single_ipi(int cpu); Could you please drop the "extern" qualifier when adding new function prototypes? I know this just follows the style of the file, but I'd prefer not to add new instances. Juergen