Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752877AbdCMIvP convert rfc822-to-8bit (ORCPT ); Mon, 13 Mar 2017 04:51:15 -0400 Received: from mga14.intel.com ([192.55.52.115]:62806 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753065AbdCMIte (ORCPT ); Mon, 13 Mar 2017 04:49:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,158,1486454400"; d="scan'208";a="74716224" From: "Patel, Mayurkumar" To: Sinan Kaya , Bjorn Helgaas CC: "linux-pci@vger.kernel.org" , "timur@codeaurora.org" , "linux-arm-msm@vger.kernel.org" , open list , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH V3] PCI/ASPM: reconfigure ASPM following hotplug for POLICY_DEFAULT Thread-Topic: [PATCH V3] PCI/ASPM: reconfigure ASPM following hotplug for POLICY_DEFAULT Thread-Index: AQHSmEwVJsQ8B/K1aUaFQpCGTkNUGKGNGC6AgAEOioCABFWqYA== Date: Mon, 13 Mar 2017 08:49:30 +0000 Message-ID: <92EBB4272BF81E4089A7126EC1E7B28466670D75@IRSMSX101.ger.corp.intel.com> References: <1489005551-23598-1-git-send-email-okaya@codeaurora.org> <20170309222751.GD19517@bhelgaas-glaptop.roam.corp.google.com> In-Reply-To: Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1501 Lines: 41 > >Hi Bjorn, > >On 3/9/2017 5:27 PM, Bjorn Helgaas wrote: >> How hard do you think it would be to rework this path slightly so we: >> >> - call pcie_aspm_init_link_state() for every device, maybe from >> pci_init_capabilities() >> >> - for bridges, have pcie_aspm_init_link_state() allocate a >> link_state, regardless of whether it currently has any children, >> and save the ASPM settings done by firmware >> >> - for endpoints, have pcie_aspm_init_link_state() do the actual ASPM >> setup of the link as it currently does >> >> - for endpoints, change pcie_aspm_exit_link_state() so it cleans up >> the device's own state and disables ASPM if necessary, but doesn't >> remove the parent's link_state >> >> - for bridges, change pcie_aspm_exit_link_state() so it frees the >> bridge's own link_state > >Thanks for the feedback, Let me take a stab at this. >Sinan Thanks Bjorn and Sinan. I will wait for new patch-sets from Sinan. > >-- >Sinan Kaya >Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. >Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928