Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752630AbdCMIvk (ORCPT ); Mon, 13 Mar 2017 04:51:40 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:35191 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752982AbdCMItA (ORCPT ); Mon, 13 Mar 2017 04:49:00 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170310174045.GB24571@leverpostej> From: Geert Uytterhoeven Date: Mon, 13 Mar 2017 09:48:51 +0100 X-Google-Sender-Auth: jMJivqpizIXUnEKIFFMrK0xupFk Message-ID: Subject: Re: Bad DT binding (hisi-pcie-almost-ecam) To: Gabriele Paoloni Cc: Mark Rutland , "liudongdong (C)" , Bjorn Helgaas , "Wangzhou (B)" , "devicetree@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1434 Lines: 40 On Mon, Mar 13, 2017 at 9:14 AM, Gabriele Paoloni wrote: > About the name to use here from what you suggest we should use > "hisilicon,hip06-pcie-almost-ecam" and re-use it for hip07 SoC. > To be honest I would prefer it either as it is now or to modify the > driver as: > > diff --git a/drivers/pci/dwc/pcie-hisi.c b/drivers/pci/dwc/pcie-hisi.c > index 52f1e3f..7527b4c 100644 > --- a/drivers/pci/dwc/pcie-hisi.c > +++ b/drivers/pci/dwc/pcie-hisi.c > @@ -381,7 +381,11 @@ struct pci_ecam_ops hisi_pcie_platform_ops = { > > static const struct of_device_id hisi_pcie_almost_ecam_of_match[] = { > { > - .compatible = "hisilicon,pcie-almost-ecam", > + .compatible = "hisilicon,pcie-almost-ecam-hip06", Shouldn't that be "hisilicon,hip06-pcie-almost-ecam"? > + .data = (void *) &hisi_pcie_platform_ops, > + }, > + { > + .compatible = "hisilicon,pcie-almost-ecam-hip07", Shouldn't that be "hisilicon,hip07-pcie-almost-ecam"? > .data = (void *) &hisi_pcie_platform_ops, > }, Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds