Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752086AbdCMJfZ (ORCPT ); Mon, 13 Mar 2017 05:35:25 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:9390 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750864AbdCMJfQ (ORCPT ); Mon, 13 Mar 2017 05:35:16 -0400 From: Gabriele Paoloni To: Geert Uytterhoeven CC: Mark Rutland , "liudongdong (C)" , Bjorn Helgaas , "Wangzhou (B)" , "devicetree@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: Bad DT binding (hisi-pcie-almost-ecam) Thread-Topic: Bad DT binding (hisi-pcie-almost-ecam) Thread-Index: AQHSmcWDRNN6g20vXkSgiBf6vOqy/KGSa0EA///9toCAAB0W8A== Date: Mon, 13 Mar 2017 09:34:54 +0000 Message-ID: References: <20170310174045.GB24571@leverpostej> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.203.181.161] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.58C667D1.007E,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=169.254.1.242, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: c4441601b5dd17eeaf4909d257395a5c Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v2D9ZT51025013 Content-Length: 972 Lines: 39 Hi Geert [...] > > { > > - .compatible = "hisilicon,pcie-almost-ecam", > > + .compatible = "hisilicon,pcie-almost-ecam-hip06", > > Shouldn't that be "hisilicon,hip06-pcie-almost-ecam"? > > > + .data = (void *) &hisi_pcie_platform_ops, > > + }, > > + { > > + .compatible = "hisilicon,pcie-almost-ecam-hip07", > > Shouldn't that be "hisilicon,hip07-pcie-almost-ecam"? Indeed prefixing the SoC name is more consistent and it looks better Many thanks Gab > > > .data = (void *) &hisi_pcie_platform_ops, > > }, > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a > hacker. But > when I'm talking to journalists I just say "programmer" or something > like that. > -- Linus Torvalds