Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752249AbdCMJnw (ORCPT ); Mon, 13 Mar 2017 05:43:52 -0400 Received: from pegasos-out.vodafone.de ([80.84.1.38]:45754 "EHLO pegasos-out.vodafone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751669AbdCMJno (ORCPT ); Mon, 13 Mar 2017 05:43:44 -0400 X-Spam-Flag: NO X-Spam-Score: -0.045 Authentication-Results: rohrpostix1.prod.vfnet.de (amavisd-new); dkim=pass header.i=@vodafone.de X-DKIM: OpenDKIM Filter v2.6.8 pegasos-out.vodafone.de 43CCC261972 Subject: Re: [PATCH 1/5] PCI: add resizeable BAR infrastructure v2 To: Andy Shevchenko References: <1488800428-2854-1-git-send-email-deathsimple@vodafone.de> Cc: "linux-pci@vger.kernel.org" , dri-devel@lists.freedesktop.org, Platform Driver , amd-gfx@lists.freedesktop.org, "linux-kernel@vger.kernel.org" From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <28e64c07-ac7f-5f1f-0b3d-0e487f8fdfd4@vodafone.de> Date: Mon, 13 Mar 2017 10:43:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 564 Lines: 15 Am 06.03.2017 um 13:20 schrieb Andy Shevchenko: > On Mon, Mar 6, 2017 at 1:40 PM, Christian König wrote: >> + for (i = 0; i < nbars; ++i, pos += 8) { > 8 is defined somewhere in the spec? (Yes, I understand that is just 64 > bits shift) Yes, it is defined in the spec, see "Figure 7-x1 Resizable BAR Capability". It just doesn't have a name or something if that's what you are asking for. I've addressed all other comments in code and will send out the next version of the patch set today. Thanks for the comments, Christian.