Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751389AbdCMJ5l (ORCPT <rfc822;w@1wt.eu>);
        Mon, 13 Mar 2017 05:57:41 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:36135 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750777AbdCMJ5g (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 13 Mar 2017 05:57:36 -0400
Date: Mon, 13 Mar 2017 10:57:33 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Masanari Iida <standby24x7@gmail.com>
cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] [linux-next] x86/smpboot: Remove duplicate inclusion of
 asm/reammode.h
In-Reply-To: <20170313093522.17391-1-standby24x7@gmail.com>
Message-ID: <alpine.DEB.2.20.1703131046370.3558@nanos>
References: <20170313093522.17391-1-standby24x7@gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1562
Lines: 48

Masanari,

On Mon, 13 Mar 2017, Masanari Iida wrote:

> Subject : [PATCH] [linux-next] x86/smpboot: Remove duplicate inclusion of 
>          asm/reammode.h

The "linux-next" tag is pointless. The duplicate include is in Linus tree
as well, so this is not linux-next specific at all.

Please be more careful with your subject lines. reammode.h ????

> This patch remove duplicate asm/realmode.h in smpboot.c

Please read Documentation/process/submitting-patches.rst. Especially the
following paragraph:

  Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
  instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to
  do frotz", as if you are giving orders to the codebase to change its
  behaviour

"This patch" is really pointless. We already know that this is a patch,
otherwise you wouldn't have sent it with the "[PATCH]" prefix in the
subject line.

> Confirm successfully compile after remove the line.

That's obvious, isn't it? If the include is duplicate the removal won't
break anything.

> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
> 
> # Please enter the commit message for your changes. Lines starting
> # with '#' will be kept; you may remove them yourself if you want to.
> # An empty message aborts the commit.
> # On branch smpboot-fix
> # Changes to be committed:
> #	modified:   arch/x86/kernel/smpboot.c
> #

Please adjust your workflow. This is not part of a changelog. It's the
comment section of the git-commit template which should not be part of your
patch submission at all.

Thanks,

	tglx