Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751856AbdCMKYp (ORCPT ); Mon, 13 Mar 2017 06:24:45 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35889 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751111AbdCMKYh (ORCPT ); Mon, 13 Mar 2017 06:24:37 -0400 Date: Mon, 13 Mar 2017 11:24:33 +0100 From: Daniel Vetter To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, open list , "open list:VIRTIO GPU DRIVER" Subject: Re: [PATCH] drm: virtio: fix kmem_cache_alloc error check Message-ID: <20170313102433.3okzlfvjwehhvplg@phenom.ffwll.local> Mail-Followup-To: Gerd Hoffmann , dri-devel@lists.freedesktop.org, open list , "open list:VIRTIO GPU DRIVER" References: <1489393346-13874-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1489393346-13874-1-git-send-email-kraxel@redhat.com> X-Operating-System: Linux phenom 4.8.0-1-amd64 User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1322 Lines: 42 On Mon, Mar 13, 2017 at 09:22:26AM +0100, Gerd Hoffmann wrote: > kmem_cache_alloc returns NULL on error, not ERR_PTR. > > Fixes: f5985bf9cadd4e3ed8d5d9a9cbbb2e39cdb81cd9 > Reported-by: Jiri Slaby > Signed-off-by: Gerd Hoffmann I guess we should have smatch integrated into 0day to catch these ... Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/virtio/virtgpu_vq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c > index 472e349..9eb96fb2 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_vq.c > +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c > @@ -97,8 +97,8 @@ void virtio_gpu_free_vbufs(struct virtio_gpu_device *vgdev) > struct virtio_gpu_vbuffer *vbuf; > > vbuf = kmem_cache_alloc(vgdev->vbufs, GFP_KERNEL); > - if (IS_ERR(vbuf)) > - return ERR_CAST(vbuf); > + if (!vbuf) > + return ERR_PTR(-ENOMEM); > memset(vbuf, 0, VBUFFER_SIZE); > > BUG_ON(size > MAX_INLINE_CMD_SIZE); > -- > 1.8.3.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch