Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751938AbdCMLUH (ORCPT ); Mon, 13 Mar 2017 07:20:07 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:22289 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750846AbdCMLUA (ORCPT ); Mon, 13 Mar 2017 07:20:00 -0400 Date: Mon, 13 Mar 2017 14:19:28 +0300 From: Dan Carpenter To: =?utf-8?B?UmFkb3PFgmF3?= Pietrzyk Cc: Thomas Petazzoni , Greg Kroah-Hartman , "open list:STAGING SUBSYSTEM" , open list Subject: Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt Message-ID: <20170313111928.GC4187@mwanda> References: <1489137927-13347-2-git-send-email-radoslaw.pietrzyk@gmail.com> <1489400925-2504-1-git-send-email-radoslaw.pietrzyk@gmail.com> <20170313110052.GB4136@mwanda> <20170313111159.GB4187@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 487 Lines: 12 On Mon, Mar 13, 2017 at 12:16:13PM +0100, Radosław Pietrzyk wrote: > Ok I will. I just have thought that in general it might be helpful to > have this possibility as DT is parsed for this option anyway. If you > think it is not needed at all that why to bother parsing DT for this > option in the first place ? I'm not saying it's a wrong patch, I just think the patch description doesn't explain why you are doing it or the user visible effects of the change. regards, dan carpenter