Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752225AbdCMLVp (ORCPT ); Mon, 13 Mar 2017 07:21:45 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:35509 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750783AbdCMLVi (ORCPT ); Mon, 13 Mar 2017 07:21:38 -0400 MIME-Version: 1.0 In-Reply-To: <20170313111928.GC4187@mwanda> References: <1489137927-13347-2-git-send-email-radoslaw.pietrzyk@gmail.com> <1489400925-2504-1-git-send-email-radoslaw.pietrzyk@gmail.com> <20170313110052.GB4136@mwanda> <20170313111159.GB4187@mwanda> <20170313111928.GC4187@mwanda> From: =?UTF-8?Q?Rados=C5=82aw_Pietrzyk?= Date: Mon, 13 Mar 2017 12:21:36 +0100 Message-ID: Subject: Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt To: Dan Carpenter Cc: Thomas Petazzoni , Greg Kroah-Hartman , "open list:STAGING SUBSYSTEM" , open list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2DBLmTi003680 Content-Length: 588 Lines: 16 Understood 2017-03-13 12:19 GMT+01:00 Dan Carpenter : > On Mon, Mar 13, 2017 at 12:16:13PM +0100, Radosław Pietrzyk wrote: >> Ok I will. I just have thought that in general it might be helpful to >> have this possibility as DT is parsed for this option anyway. If you >> think it is not needed at all that why to bother parsing DT for this >> option in the first place ? > > I'm not saying it's a wrong patch, I just think the patch description > doesn't explain why you are doing it or the user visible effects of the > change. > > regards, > dan carpenter >