Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752339AbdCMMMW (ORCPT ); Mon, 13 Mar 2017 08:12:22 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:46419 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750802AbdCMMMP (ORCPT ); Mon, 13 Mar 2017 08:12:15 -0400 Date: Mon, 13 Mar 2017 15:11:10 +0300 From: Dan Carpenter To: Greg KH Cc: Craig Inches , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, oleg.drokin@intel.com, andreas.dilger@intel.com, lustre-devel@lists.lustre.org Subject: Re: [PATCH] staging: lustre fix constant comparision style issue in lu_object.h Message-ID: <20170313121110.GD4136@mwanda> References: <20170311130740.11488-1-Craig@craiginches.com> <20170312133722.GC27791@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170312133722.GC27791@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 486 Lines: 13 On Sun, Mar 12, 2017 at 02:37:22PM +0100, Greg KH wrote: > On Sat, Mar 11, 2017 at 01:07:40PM +0000, Craig Inches wrote: > > This patch resolves the "Comparisons should place the constant on > > the right side of the test" found with checkpatch tool. > > Both are constants, I think checkpatch is the thing that is wrong here, > don't you agree? Sort of constant-ish... The sizeof(*value) changes each time the macro is used. I feel like checkpatch is right. regads, dan carpenter