Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753275AbdCMMvL (ORCPT ); Mon, 13 Mar 2017 08:51:11 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:46518 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752396AbdCMMuw (ORCPT ); Mon, 13 Mar 2017 08:50:52 -0400 Date: Mon, 13 Mar 2017 13:50:41 +0100 From: Peter Zijlstra To: Madhavan Srinivasan Cc: mpe@ellerman.id.au, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Sukadev Bhattiprolu , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Wang Nan , Alexei Starovoitov , Stephane Eranian Subject: Re: [PATCH v2 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src Message-ID: <20170313125041.GB3328@twins.programming.kicks-ass.net> References: <1488796993-25495-1-git-send-email-maddy@linux.vnet.ibm.com> <1488796993-25495-2-git-send-email-maddy@linux.vnet.ibm.com> <20170306112228.GZ6515@twins.programming.kicks-ass.net> <2fc7e466-1675-ef27-b820-ef33ed0be7da@linux.vnet.ibm.com> <20170307102359.GE6515@twins.programming.kicks-ass.net> <78c1b95d-2e82-f998-74ba-ebb1fdf5bb45@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <78c1b95d-2e82-f998-74ba-ebb1fdf5bb45@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 460 Lines: 10 On Mon, Mar 13, 2017 at 04:45:51PM +0530, Madhavan Srinivasan wrote: > > - should you not have fixed this in the tool only? This patch > > effectively breaks ABI on big-endian architectures. > > IIUC, we are the first BE user for this feature > (Kindly correct me if I am wrong), so technically we > are not breaking ABI here :) . But let me also look at > the dynamic conversion part. Huh? PPC hasn't yet implemented this? Then why are you fixing it?