Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753018AbdCMOr0 (ORCPT ); Mon, 13 Mar 2017 10:47:26 -0400 Received: from mail.kernel.org ([198.145.29.136]:44456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbdCMOrU (ORCPT ); Mon, 13 Mar 2017 10:47:20 -0400 Date: Mon, 13 Mar 2017 11:47:14 -0300 From: Arnaldo Carvalho de Melo To: changbin.du@intel.com Cc: peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf report: show sort_order in title Message-ID: <20170313144714.GO2750@kernel.org> References: <20170313083635.24525-1-changbin.du@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170313083635.24525-1-changbin.du@intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1889 Lines: 61 Em Mon, Mar 13, 2017 at 04:36:35PM +0800, changbin.du@intel.com escreveu: > From: Changbin Du > > In the report, how does the data sort is a important info for > analyser. Moreover, perf sometimes insert or append sort fields > automatically. Thus user may confuse how it sorts w/o reading > perf internal. So here print the order info to repor title. > > Signed-off-by: Changbin Du > --- > tools/perf/ui/browsers/hists.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c > index fc4fb66..6c6b615 100644 > --- a/tools/perf/ui/browsers/hists.c > +++ b/tools/perf/ui/browsers/hists.c > @@ -2194,6 +2194,25 @@ static inline bool is_report_browser(void *timer) > return timer == NULL; > } > > +static int get_sort_fields_str(struct hists *hists, char *buf, size_t size) I'll just rename this to use the tools/perf/ style for such functions, making it: static int hists__scnprintf_sort_fields(hists, buf, size) > +{ > + struct perf_hpp_fmt *fmt; > + bool first = true; > + int ret = 0; > + > + hists__for_each_sort_list(hists, fmt) { > + if (first) { > + first = false; > + ret += scnprintf(buf + ret, size - ret, "%s", fmt->name); > + } else { > + ret += scnprintf(buf + ret, size - ret, ",%s", fmt->name); > + } > + if (size - ret <= 0) > + break; > + } > + return ret; > +} > + > static int perf_evsel_browser_title(struct hist_browser *browser, > char *bf, size_t size) > { > @@ -2274,6 +2293,9 @@ static int perf_evsel_browser_title(struct hist_browser *browser, > printed += scnprintf(bf + printed, size - printed, " [z]"); > } > > + get_sort_fields_str(hists, buf, sizeof(buf)); > + printed += scnprintf(bf + printed, size - printed, ", Sort by: %s", buf); > + > return printed; > } > > -- > 2.7.4