Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753531AbdCMOzy convert rfc822-to-8bit (ORCPT ); Mon, 13 Mar 2017 10:55:54 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:54328 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753328AbdCMOzs (ORCPT ); Mon, 13 Mar 2017 10:55:48 -0400 From: Vivien Didelot To: Florian Fainelli , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn Subject: Re: [PATCH net-next v2 12/17] net: dsa: add dsa_is_normal_port helper In-Reply-To: References: <20170311211303.24560-1-vivien.didelot@savoirfairelinux.com> <20170311211303.24560-13-vivien.didelot@savoirfairelinux.com> Date: Mon, 13 Mar 2017 10:54:35 -0400 Message-ID: <871su1p6qc.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 454 Lines: 17 Hi Florian, Florian Fainelli writes: > Le 03/11/17 à 13:12, Vivien Didelot a écrit : >> Introduce a dsa_is_normal_port helper to check if a given port is a >> normal user port as opposed to a CPU port or DSA link. > > net/dsa/dsa2.c uses the "user" terminology should we use something like > that here? I used the one suggested by Andrew, but I wouldn't mind using "user" here if it makes more sense. Thanks, Vivien