Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753159AbdCMQRP (ORCPT ); Mon, 13 Mar 2017 12:17:15 -0400 Received: from mail-qk0-f173.google.com ([209.85.220.173]:36027 "EHLO mail-qk0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752358AbdCMQRI (ORCPT ); Mon, 13 Mar 2017 12:17:08 -0400 MIME-Version: 1.0 In-Reply-To: <2e954caa-d531-3c82-023c-afb8aaf9f3d9@canonical.com> References: <20170309093651.7824-1-kernel@kempniu.pl> <2e954caa-d531-3c82-023c-afb8aaf9f3d9@canonical.com> From: Andy Shevchenko Date: Mon, 13 Mar 2017 18:17:06 +0200 Message-ID: Subject: Re: [PATCH] platform/x86: intel-hid: do not set parents of input devices explicitly To: Alex Hung Cc: =?UTF-8?B?TWljaGHFgiBLxJlwaWXFhA==?= , Darren Hart , Andy Shevchenko , Platform Driver , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2DGHJba002357 Content-Length: 715 Lines: 24 On Mon, Mar 13, 2017 at 12:37 PM, Alex Hung wrote: > On 2017-03-09 05:36 PM, Michał Kępień wrote: >> >> devm_input_allocate_device() already causes the supplied struct device >> to be set as the parent of the input device, so doing it again is >> redundant. >> >> Signed-off-by: Michał Kępień Pushed to testing, thanks. > > The patch, on top of previous patches, is tested on Latitude 7480 > > Reviewed-and-tested-by: Alex Hung Alex, this tag is not recognized by patchwork :-(, It would be nice to use separate tags. I would join them if needed (usually when they sent against cover letter). -- With Best Regards, Andy Shevchenko