MIME-Version: 1.0
In-Reply-To: <2f21aeb3-dd4e-e170-729a-a785077b6f28@xilinx.com>
References: <1489181435-3151-1-git-send-email-mdf@kernel.org>
 <1489181435-3151-2-git-send-email-mdf@kernel.org> <CAAtXAHe-AMq9Ux2LZZEWLcg8Dk6jTiHhrot4RhEVrxTBhnLE0g@mail.gmail.com>
 <2f21aeb3-dd4e-e170-729a-a785077b6f28@xilinx.com>
From: Moritz Fischer <moritz.fischer.private@gmail.com>
Date: Mon, 13 Mar 2017 09:18:31 -0700
Message-ID: <CAJYdmeM+OkvNHtXR7o7R7s418Q52KGDFH5B-oKWeMq-tkmwW2Q@mail.gmail.com>
Subject: Re: [PATCH 2/2] fpga: Add support for Xilinx LogiCORE PR Decoupler
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-fpga@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        =?UTF-8?Q?S=C3=B6ren_Brinkmann?= <soren.brinkmann@xilinx.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Devicetree List <devicetree@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1740
Lines: 46

On Mon, Mar 13, 2017 at 3:27 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> Hi Moritz,
>
> On 10.3.2017 23:42, Moritz Fischer wrote:
>> On Fri, Mar 10, 2017 at 1:30 PM, Moritz Fischer <mdf@kernel.org> wrote:
>>> This adds support for the Xilinx LogiCORE PR Decoupler
>>> soft-ip that does decoupling of PR regions in the FPGA
>>> fabric during partial reconfiguration.
>>>
>>> Signed-off-by: Moritz Fischer <mdf@kernel.org>
>>> Cc: Michal Simek <michal.simek@xilinx.com>
>>> Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
>>> Cc: linux-kernel@vger.kernel.org
>>> Cc: devicetree@vger.kernel.org
>>> ---
>>>  drivers/fpga/Kconfig               |   9 +++
>>>  drivers/fpga/Makefile              |   1 +
>>>  drivers/fpga/xilinx-pr-decoupler.c | 156 +++++++++++++++++++++++++++++++++++++
>>>  3 files changed, 166 insertions(+)
>>>  create mode 100644 drivers/fpga/xilinx-pr-decoupler.c
>
> I have written very similar driver some week ago but didn't sent it out.

Hah. I'll take a look.

> Here it is.
> https://github.com/Xilinx/linux-xlnx/blob/master/drivers/fpga/xilinx-pr-decoupler.c
>
> Your clk handling is better and my enable_show is better.
> You shouldn't rely on setting status before. It is better to read that
> reg again. The reason is you can connect status signal from one PR
> decoupler to decouple input which can change status

I will just merge them together and add you to author's list if that's
fine with you?

> There is another topic I wanted to open in connection to this. There
> should be gpio based bridge because this pr decoupler can be without axi
> interface and for that gpio driver would be useful.

That's a good idea. I can look at that. This can be pretty generic
code I suppose.

Cheers,

Moritz