Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753057AbdCMQdI (ORCPT ); Mon, 13 Mar 2017 12:33:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56176 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751089AbdCMQby (ORCPT ); Mon, 13 Mar 2017 12:31:54 -0400 Date: Mon, 13 Mar 2017 12:31:53 -0400 From: Jessica Yu To: Paul Moore Cc: Richard Guy Briggs , linux-kernel@vger.kernel.org, linux-audit@redhat.com Subject: Re: [PATCH v2] audit: log module name on delete_module Message-ID: <20170313163126.GA8117@packer-debian-8-amd64.digitalocean.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-OS: Linux eisen.io 3.16.0-4-amd64 x86_64 User-Agent: Mutt/1.5.23 (2014-03-12) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 13 Mar 2017 16:31:54 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1612 Lines: 49 +++ Paul Moore [13/03/17 10:16 -0400]: >On Sat, Mar 11, 2017 at 9:24 PM, Richard Guy Briggs wrote: >> When a sysadmin wishes to monitor module unloading with a syscall rule such as: >> -a always,exit -F arch=x86_64 -S delete_module -F key=mod-unload >> the SYSCALL record doesn't tell us what module was requested for unloading. >> >> Use the new KERN_MODULE auxiliary record to record it. >> The SYSCALL record result code will list the return code. >> >> See: https://github.com/linux-audit/audit-kernel/issues/37 >> https://github.com/linux-audit/audit-kernel/issues/7 >> https://github.com/linux-audit/audit-kernel/wiki/RFE-Module-Load-Record-Format >> >> Signed-off-by: Richard Guy Briggs >> --- >> kernel/module.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) > >Jessica? If there are no objections to this patch on your side I'll >merge this into the audit/next tree. Looks good to me: Acked-by: Jessica Yu >> diff --git a/kernel/module.c b/kernel/module.c >> index 5432dbe..633f6da 100644 >> --- a/kernel/module.c >> +++ b/kernel/module.c >> @@ -943,6 +943,8 @@ SYSCALL_DEFINE2(delete_module, const char __user *, name_user, >> return -EFAULT; >> name[MODULE_NAME_LEN-1] = '\0'; >> >> + audit_log_kern_module(name); >> + >> if (mutex_lock_interruptible(&module_mutex) != 0) >> return -EINTR; >> >> -- >> 1.7.1 >> >> -- >> Linux-audit mailing list >> Linux-audit@redhat.com >> https://www.redhat.com/mailman/listinfo/linux-audit > >-- >paul moore >www.paul-moore.com