Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753705AbdCMQgw (ORCPT ); Mon, 13 Mar 2017 12:36:52 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:46199 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752557AbdCMQgb (ORCPT ); Mon, 13 Mar 2017 12:36:31 -0400 Date: Mon, 13 Mar 2017 17:36:24 +0100 From: Andrew Lunn To: sean.wang@mediatek.com Cc: f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, matthias.bgg@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, davem@davemloft.net, Landen.Chao@mediatek.com, keyhaede@gmail.com, objelf@gmail.com Subject: Re: [PATCH net-next 1/4] dt-bindings: net: dsa: add Mediatek MT7530 binding Message-ID: <20170313163624.GD3953@lunn.ch> References: <1489421488-300-1-git-send-email-sean.wang@mediatek.com> <1489421488-300-2-git-send-email-sean.wang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1489421488-300-2-git-send-email-sean.wang@mediatek.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 566 Lines: 17 > +- mediatek,reset-pin: Phandle to the pinctrl node used for the reset. Which > + must be required if the property mediatek,mcm of specified as > + "disabled". See > + Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt for > + the mediatek pintcrl setting for the details. Hi Sean This appears to be a plan GPIO line. Marvell has the same. It would be nice to be consistent with the naming. From Documentation/devicetree/bindings/net/dsa/marvell.txt Optional properties: - reset-gpios : Should be a gpio specifier for a reset line Andrew