Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754130AbdCMQ4K (ORCPT ); Mon, 13 Mar 2017 12:56:10 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:36013 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752397AbdCMQz4 (ORCPT ); Mon, 13 Mar 2017 12:55:56 -0400 MIME-Version: 1.0 In-Reply-To: References: <20161216092017.2560717-1-arnd@arndb.de> From: Arnd Bergmann Date: Mon, 13 Mar 2017 17:55:54 +0100 X-Google-Sender-Auth: qM1-3KeU1BUuqXIRTVt75YEmP90 Message-ID: Subject: Re: [PATCH net 1/3] cpsw/netcp: cpts depends on posix_timers To: Nicolas Pitre Cc: "David S. Miller" , Grygorii Strashko , Thomas Gleixner , John Stultz , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , WingMan Kwok , Networking , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1072 Lines: 24 On Fri, Dec 16, 2016 at 7:18 PM, Nicolas Pitre wrote: > On Fri, 16 Dec 2016, Arnd Bergmann wrote: > >> With posix timers having become optional, we get a build error with >> the cpts time sync option of the CPSW driver: >> >> drivers/net/ethernet/ti/cpts.c: In function 'cpts_find_ts': >> drivers/net/ethernet/ti/cpts.c:291:23: error: implicit declaration of function 'ptp_classify_raw';did you mean 'ptp_classifier_init'? [-Werror=implicit-function-declaration] >> >> It really makes no sense to build this driver if we can't use PTP, >> so it's better to go back to 'select PTP_1588_CLOCK' but instead >> add a dependency on POSIX_TIMERS. > > Why not depend on PTP_1588_CLOCK directly instead? Sorry for dropping the ball on this. I just noticed my two patches in my patch are still required, so I'm resending them now. I think using 'select' here is better for consistency as we use 'imply' elsewhere, and mixing the two might cause circular dependencies. If you still have concerns about this, please follow up on the resend. Arnd