Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932173AbdCMR1U (ORCPT ); Mon, 13 Mar 2017 13:27:20 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:42776 "EHLO imgpgp01.kl.imgtec.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750814AbdCMR1N (ORCPT ); Mon, 13 Mar 2017 13:27:13 -0400 X-PGP-Universal: processed; by imgpgp01.kl.imgtec.org on Mon, 13 Mar 2017 18:32:22 +0000 From: Paul Burton To: Geliang Tang CC: Miguel Ojeda Sandonis , , Ralf Baechle , Andrew Morton , Subject: Re: [PATCH] auxdisplay: use setup_timer Date: Mon, 13 Mar 2017 10:27:02 -0700 Message-ID: <1591174.23lsdrNnms@np-p-burton> Organization: Imagination Technologies In-Reply-To: References: <3afa5498142ef68256023257dad37b9f8352e65e.1489060803.git.geliangtang@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart14897560.Dg81N7sMQO"; micalg=pgp-sha256; protocol="application/pgp-signature" X-Originating-IP: [10.20.1.33] X-ESG-ENCRYPT-TAG: 1b7d744b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2672 Lines: 67 --nextPart14897560.Dg81N7sMQO Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi Geliang, On Friday, 10 March 2017 16:46:57 PDT Geliang Tang wrote: > Use setup_timer() instead of init_timer() to simplify the code. > > Signed-off-by: Geliang Tang > --- > drivers/auxdisplay/img-ascii-lcd.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/auxdisplay/img-ascii-lcd.c > b/drivers/auxdisplay/img-ascii-lcd.c index bf43b5d..1f30b7e 100644 > --- a/drivers/auxdisplay/img-ascii-lcd.c > +++ b/drivers/auxdisplay/img-ascii-lcd.c > @@ -393,9 +393,7 @@ static int img_ascii_lcd_probe(struct platform_device > *pdev) ctx->scroll_rate = HZ / 2; > > /* initialise a timer for scrolling the message */ > - init_timer(&ctx->timer); > - ctx->timer.function = img_ascii_lcd_scroll; > - ctx->timer.data = (unsigned long)ctx; > + setup_timer(&ctx->timer, img_ascii_lcd_scroll, (unsigned long)ctx); > > platform_set_drvdata(pdev, ctx); Thanks for the patch: Reviewed-by: Paul Burton I've CC'd Ralf & Andrew since a couple of other patches to this driver have been waiting for someone to merge them for a while, and whilst it's unclear which path those patches & this one should take into mainline they've been suggested so far (besides Miguel who seems not to be active). I've also CC'd the trivial patch monkey in case this can get in through that route, though I'm unsure whether CC'ing on a reply is sufficient so you might like to resend with trivial@kernel.org CC'd on the patch. Thanks, Paul --nextPart14897560.Dg81N7sMQO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEELIGR03D5+Fg+69wPgiDZ+mk8HGUFAljG1mYACgkQgiDZ+mk8 HGU6jQ/+Ovw8SoD39o1SFB6nCR4q/azSz7uCkPeiYn1CQDcIfNd6nromgyrimkiw gT/9kfPzMSWK4f0QZLIqqkL3kgkesni9VyJ8XEuYYEDSZVA2MYZU07/+vk0ACppA rR90E8V1+NRr0Rq4nLBQxIEP8lTPvuKx94WCQ41pc6BBCw9GiYrdmZVHWiReLI8w E7FjRVA3sF62yBeb8fM0ouRnwmXF5tdx+jXLRhxHprHK2k5KycschyjpQ5Nk8F9q zyzDxCjqqhT4NOsIjKmK8ULIg94Pt6eLX0zSNzanOFZKt4rR468xWqwmdtwSehso weQSNLluRcxQbBN4NnHXz5tV2PZY5lTb3KkdSOpXbAwl456NVjJ1WNI915Es/yJ6 sOr5hYnlpaHOMT2dQbE6DcMF15sRmTPPd3aIS4bvwjValeqsH6hLaeTlV0wCVLQn GmU1gUJshuNyFfyq7X4TXkMvh1MKggb3xSYTyi0KcFQbWgsVY/h8kuQKhZ5zlqAv EeBtx8EnAxIy990CSIjPmT/bOvVwk7RnlBagZvn99hvbvZ459TaunD2C/+gFtmC3 jwo5wMDZioqdm/szwNQ2I9x75r5LL0k9aRq/4braTf/0HFe65mhOEPCGeoPymuSA fKN4Usyw+3GWvKjuO+X2Ji85mjoOrrqQRGmzrnLNW9xW1mPilAU= =oWQs -----END PGP SIGNATURE----- --nextPart14897560.Dg81N7sMQO--