Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754556AbdCMRi4 (ORCPT ); Mon, 13 Mar 2017 13:38:56 -0400 Received: from mail07.usask.ca ([128.233.195.244]:53934 "EHLO mail.usask.ca" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753219AbdCMRip (ORCPT ); Mon, 13 Mar 2017 13:38:45 -0400 Subject: Re: [PATCH] net: usb: asix88179_178a: use new api ethtool_{get|set}_link_ksettings To: Philippe Reynes , , , References: <1489338156-18632-1-git-send-email-tremyfr@gmail.com> CC: , , From: Chris Roth Message-ID: <127bb0ec-82e7-6aee-f70a-323de6f00e97@usask.ca> Date: Mon, 13 Mar 2017 11:38:41 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1489338156-18632-1-git-send-email-tremyfr@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2302 Lines: 62 I have tested this patch on the Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller (Vendor=04b4 ProdID=3610) and the device still functions properly with the patch applied. Feel free to add my name / email to the tested-by portion of the patch. Chris On 2017-03-12 11:02 AM, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > > Signed-off-by: Philippe Reynes > --- > drivers/net/usb/ax88179_178a.c | 14 ++++++++------ > 1 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c > index a3a7db0..4a0ae7c 100644 > --- a/drivers/net/usb/ax88179_178a.c > +++ b/drivers/net/usb/ax88179_178a.c > @@ -620,16 +620,18 @@ static int ax88179_get_eeprom_len(struct net_device *net) > return 0; > } > > -static int ax88179_get_settings(struct net_device *net, struct ethtool_cmd *cmd) > +static int ax88179_get_link_ksettings(struct net_device *net, > + struct ethtool_link_ksettings *cmd) > { > struct usbnet *dev = netdev_priv(net); > - return mii_ethtool_gset(&dev->mii, cmd); > + return mii_ethtool_get_link_ksettings(&dev->mii, cmd); > } > > -static int ax88179_set_settings(struct net_device *net, struct ethtool_cmd *cmd) > +static int ax88179_set_link_ksettings(struct net_device *net, > + const struct ethtool_link_ksettings *cmd) > { > struct usbnet *dev = netdev_priv(net); > - return mii_ethtool_sset(&dev->mii, cmd); > + return mii_ethtool_set_link_ksettings(&dev->mii, cmd); > } > > static int > @@ -826,11 +828,11 @@ static int ax88179_ioctl(struct net_device *net, struct ifreq *rq, int cmd) > .set_wol = ax88179_set_wol, > .get_eeprom_len = ax88179_get_eeprom_len, > .get_eeprom = ax88179_get_eeprom, > - .get_settings = ax88179_get_settings, > - .set_settings = ax88179_set_settings, > .get_eee = ax88179_get_eee, > .set_eee = ax88179_set_eee, > .nway_reset = usbnet_nway_reset, > + .get_link_ksettings = ax88179_get_link_ksettings, > + .set_link_ksettings = ax88179_set_link_ksettings, > }; > > static void ax88179_set_multicast(struct net_device *net)