Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753481AbdCMSJ2 (ORCPT ); Mon, 13 Mar 2017 14:09:28 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:36698 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750846AbdCMSJT (ORCPT ); Mon, 13 Mar 2017 14:09:19 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170313164421.1090339-1-arnd@arndb.de> From: Emil Velikov Date: Mon, 13 Mar 2017 18:09:17 +0000 Message-ID: Subject: Re: [RESEND PATCH] drm/msm: adreno: fix build error without debugfs To: Rob Clark Cc: Arnd Bergmann , linux-arm-msm , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , stable , freedreno@lists.freedesktop.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 977 Lines: 22 On 13 March 2017 at 17:00, Rob Clark wrote: > On Mon, Mar 13, 2017 at 12:43 PM, Arnd Bergmann wrote: >> The newly added a5xx support fails to build when debugfs is diabled: >> >> drivers/gpu/drm/msm/adreno/a5xx_gpu.c:849:4: error: 'struct msm_gpu_funcs' has no member named 'show' >> drivers/gpu/drm/msm/adreno/a5xx_gpu.c:849:11: error: 'a5xx_show' undeclared here (not in a function); did you mean 'a5xx_irq'? >> >> This adds a missing #ifdef. >> >> Fixes: b5f103ab98c7 ("drm/msm: gpu: Add A5XX target support") >> Cc: stable@vger.kernel.org >> Signed-off-by: Arnd Bergmann > > I thought I had picked this one up already, but I guess my brain was > playing tricks on me.. I've pushed this to msm-next for now and will > cherry-pick this over to a -fixes branch when I send fixes for 4.11.. > Sean sent a similar patch last week. I think he picked it (alongside others) in drm-misc-fixes. Haven't checked though ;-) -Emil