Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754141AbdCMSgk (ORCPT ); Mon, 13 Mar 2017 14:36:40 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:34600 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751563AbdCMSgb (ORCPT ); Mon, 13 Mar 2017 14:36:31 -0400 Subject: Re: [PATCH v5 2/4] dt-bindings: mfd: Add LED subnode binding for MT6323 PMIC To: Matthias Brugger , sean.wang@mediatek.com, rpurdie@rpsys.net, lee.jones@linaro.org, pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com References: <1488549385-19899-1-git-send-email-sean.wang@mediatek.com> <1488549385-19899-3-git-send-email-sean.wang@mediatek.com> Cc: devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, keyhaede@gmail.com From: Jacek Anaszewski X-Enigmail-Draft-Status: N1110 Message-ID: Date: Mon, 13 Mar 2017 19:35:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1705 Lines: 53 Hi Matthias, On 03/13/2017 01:00 PM, Matthias Brugger wrote: > > > On 03/03/17 14:56, sean.wang@mediatek.com wrote: >> From: Sean Wang >> >> This patch adds documentation for devicetree bindings >> for LED support as the subnode of MT6323 PMIC >> >> Signed-off-by: Sean Wang >> --- >> Documentation/devicetree/bindings/mfd/mt6397.txt | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt >> b/Documentation/devicetree/bindings/mfd/mt6397.txt >> index 949c85f..522a3bb 100644 >> --- a/Documentation/devicetree/bindings/mfd/mt6397.txt >> +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt >> @@ -6,6 +6,7 @@ MT6397/MT6323 is a multifunction device with the >> following sub modules: >> - Audio codec >> - GPIO >> - Clock >> +- LED >> >> It is interfaced to host controller using SPI interface by a >> proprietary hardware >> called PMIC wrapper or pwrap. MT6397/MT6323 MFD is a child device of >> pwrap. >> @@ -34,6 +35,10 @@ Optional subnodes: >> - clk >> Required properties: >> - compatible: "mediatek,mt6397-clk" >> +- led >> + Required properties: >> + - compatible: "mediatek,mt6323-led" >> + see Documentation/devicetree/bindings/leds/leds-mt6323.txt > > Part of this patch is already part of linux-next: > 05daab3 ("Documentation: devicetree: Add LED subnode binding for MT6323 > PMIC") Yes, it's been merged via mfd tree. It doesn't break anything besides that it points to non-existent file. Hopefully we will manage to merge the LED part before merge window, otherwise the mfd part will have to be dropped. -- Best regards, Jacek Anaszewski