Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753840AbdCMS6U (ORCPT ); Mon, 13 Mar 2017 14:58:20 -0400 Received: from mail-pg0-f47.google.com ([74.125.83.47]:35972 "EHLO mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754226AbdCMS6J (ORCPT ); Mon, 13 Mar 2017 14:58:09 -0400 From: Matthias Kaehlcke To: Arnd Bergmann , Greg Kroah-Hartman , Clemens Ladisch Cc: linux-kernel@vger.kernel.org, Grant Grundler , Matthias Kaehlcke Subject: [PATCH v1] hpet: Make cmd parameter of hpet_ioctl_common() unsigned Date: Mon, 13 Mar 2017 11:57:25 -0700 Message-Id: <20170313185725.144873-1-mka@chromium.org> X-Mailer: git-send-email 2.12.0.246.ga2ecc84866-goog Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1287 Lines: 35 The value passed by the two callers of the function is unsigned anyway. Making the parameter unsigned fixes the following warning when building with clang: drivers/char/hpet.c:588:7: error: overflow converting case value to switch condition type (2149083139 to 18446744071563667459) [-Werror,-Wswitch] case HPET_INFO: ^ include/uapi/linux/hpet.h:18:19: note: expanded from macro 'HPET_INFO' ^ include/uapi/asm-generic/ioctl.h:77:28: note: expanded from macro '_IOR' ^ include/uapi/asm-generic/ioctl.h:66:2: note: expanded from macro '_IOC' (((dir) << _IOC_DIRSHIFT) | \ Signed-off-by: Matthias Kaehlcke --- drivers/char/hpet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c index 20b32bb8c2af..0d633b76c29e 100644 --- a/drivers/char/hpet.c +++ b/drivers/char/hpet.c @@ -574,7 +574,7 @@ static inline unsigned long hpet_time_div(struct hpets *hpets, } static int -hpet_ioctl_common(struct hpet_dev *devp, int cmd, unsigned long arg, +hpet_ioctl_common(struct hpet_dev *devp, unsigned int cmd, unsigned long arg, struct hpet_info *info) { struct hpet_timer __iomem *timer; -- 2.12.0.246.ga2ecc84866-goog