Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932077AbdCMTpL (ORCPT ); Mon, 13 Mar 2017 15:45:11 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58856 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752037AbdCMTpD (ORCPT ); Mon, 13 Mar 2017 15:45:03 -0400 Date: Mon, 13 Mar 2017 12:45:00 -0700 From: Andrew Morton To: Minchan Kim Cc: , , , Johannes Weiner , Michal Hocko , "Kirill A. Shutemov" , Anshuman Khandual Subject: Re: [PATCH v1 09/10] mm: make rmap_one boolean function Message-Id: <20170313124500.ffc91fa4d4077719928e3274@linux-foundation.org> In-Reply-To: <1489365353-28205-10-git-send-email-minchan@kernel.org> References: <1489365353-28205-1-git-send-email-minchan@kernel.org> <1489365353-28205-10-git-send-email-minchan@kernel.org> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 525 Lines: 13 On Mon, 13 Mar 2017 09:35:52 +0900 Minchan Kim wrote: > rmap_one's return value controls whether rmap_work should contine to > scan other ptes or not so it's target for changing to boolean. > Return true if the scan should be continued. Otherwise, return false > to stop the scanning. > > This patch makes rmap_one's return value to boolean. "SWAP_AGAIN" conveys meaning to the reader, whereas the meaning of "true" is unclear. So it would be better to document the return value of these functions.