Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754525AbdCMTtA (ORCPT <rfc822;w@1wt.eu>);
        Mon, 13 Mar 2017 15:49:00 -0400
Received: from mail-qt0-f182.google.com ([209.85.216.182]:32808 "EHLO
        mail-qt0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752982AbdCMTsv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 13 Mar 2017 15:48:51 -0400
Date: Mon, 13 Mar 2017 15:48:48 -0400
From: Sean Paul <seanpaul@chromium.org>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Rob Clark <robdclark@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        stable <stable@vger.kernel.org>, freedreno@lists.freedesktop.org
Subject: Re: [RESEND PATCH] drm/msm: adreno: fix build error without debugfs
Message-ID: <20170313194848.GW20329@art_vandelay>
References: <20170313164421.1090339-1-arnd@arndb.de>
 <CAF6AEGsDXaz9+OkJyB5=TqhWXOHtr-0Ce4953hUALJUSarg4+A@mail.gmail.com>
 <CACvgo50UXh9Xqnf0nsx+tntS57N1v=xHbhRkddPDOVtgas4xgA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACvgo50UXh9Xqnf0nsx+tntS57N1v=xHbhRkddPDOVtgas4xgA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1473
Lines: 36

On Mon, Mar 13, 2017 at 06:09:17PM +0000, Emil Velikov wrote:
> On 13 March 2017 at 17:00, Rob Clark <robdclark@gmail.com> wrote:
> > On Mon, Mar 13, 2017 at 12:43 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> >> The newly added a5xx support fails to build when debugfs is diabled:
> >>
> >> drivers/gpu/drm/msm/adreno/a5xx_gpu.c:849:4: error: 'struct msm_gpu_funcs' has no member named 'show'
> >> drivers/gpu/drm/msm/adreno/a5xx_gpu.c:849:11: error: 'a5xx_show' undeclared here (not in a function); did you mean 'a5xx_irq'?
> >>
> >> This adds a missing #ifdef.
> >>
> >> Fixes: b5f103ab98c7 ("drm/msm: gpu: Add A5XX target support")
> >> Cc: stable@vger.kernel.org
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > I thought I had picked this one up already, but I guess my brain was
> > playing tricks on me.. I've pushed this to msm-next for now and will
> > cherry-pick this over to a -fixes branch when I send fixes for 4.11..
> >
> Sean sent a similar patch last week. I think he picked it (alongside
> others) in drm-misc-fixes.
> Haven't checked though ;-)

Indeed [1]. I pushed it to drm-misc-fixes, but I don't see it there any longer.

At any rate, I'm glad we got the fix merged somewhere.

Sean

[1]- https://lists.freedesktop.org/archives/dri-devel/2017-March/134876.html

> 
> -Emil
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel